Re: [mpls] MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv

["Adrian Farrel" <[e-mail]>]

Thanks Eric,

[Adding the MPLS list]

I just posted a revised I-D.

Adrian

> -----Original Message-----
> From: Eric Osborne (eosborne) [mailto:[e-mail]]
> Sent: 20 May 2013 17:11
> To: Loa Andersson; Lizhong Jin; Jia He; Gregory Mirsky; Martin Vigoureux
> Cc: [e-mail]; mpls-
> [e-mail]
> Subject: RE: MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv
> 
> I have completed my review of this draft.  I have no issues with it, only a
few nits
> that I only pick in order to demonstrate that I have in fact actually read the
> document.
> 
> - The first sentence in section 1 is kind of bumpy.  I suggest something along
the
> lines of
> 
> ---
> RFC4385 says that if the first nibble of a PW packet carried over an MPLS
network
> has a value of 1 then the packet starts with a specific header format called
the
> Pseudowire Associated Channel Header, known as the PWACH or more generally
> as the ACH.
> ---
> 
> At a minimum, "defines that is the first" and "header format call the" are
typos.
> 
> 
> - Section 1 goes on to say "There are no currently live Internet-Drafts that
utilize
> ACH TLVs".  Is this a sentence that should live in perpetuity when this draft
> becomes an RFC?
> 
> - The security section suggests that removing the ACH TLV has a 'marginal
positive
> effect', but this ignores the idea that one could have an authentication TLV
or
> some sort of encrypted message; removing this capability has as much of a
> theoretical marginally negative effect as removing a vector for buffer bloat
or
> bogus TLV values.
> 
> 
> 
> 
> 
> eric
> 
> 
> > -----Original Message-----
> > From: Loa Andersson [mailto:[e-mail]]
> > Sent: Wednesday, May 08, 2013 4:01 AM
> > To: Lizhong Jin; Jia He; Gregory Mirsky; Eric Osborne (eosborne); Martin
> > Vigoureux
> > Cc: [e-mail]; mpls-
> > [e-mail]
> > Subject: MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv
> >
> > Jia, Lizhong, Greg and Eric,
> >
> > You have been selected as an MPLS Review team reviewers for draft-
> > farbryantrel-mpls-retire-ach-tlv-00.
> >
> > Note to authors: You have been CC'd on this email so that you can know
> > that this review is going on. However, please do not review your own
> > document.
> >
> > Reviews should comment on whether the document is coherent, is it useful
> > (ie, is it likely to be actually useful in operational networks), and is
> > the document technically sound?  We are interested in knowing whether
> > the document is ready to be considered for WG adoption (ie, it doesn't
> > have to be perfect at this point, but should be a good start).
> >
> > Reviews should be sent to the document authors, WG co-chairs and WG
> > secretary, and CC'd to the MPLS WG email list. If necessary, comments
> > may be sent privately to only the WG chairs.
> >
> > Are you able to review this draft by Mat 24, 2013?
> >
> > Thanks, Loa
> > (as MPLS WG chair)
> > --
> >
> >
> > Loa Andersson                        email: [e-mail]
> > Senior MPLS Expert                          [e-mail]
> > Huawei Technologies (consultant)     phone: [phone]