Re: [mpls] MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv

"Adrian Farrel" <adrian@olddog.co.uk> Fri, 24 May 2013 12:47 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D30E21F9012 for <mpls@ietfa.amsl.com>; Fri, 24 May 2013 05:47:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.971
X-Spam-Level:
X-Spam-Status: No, score=-0.971 tagged_above=-999 required=5 tests=[AWL=-1.161, BAYES_00=-2.599, CN_BODY_35=0.339, MIME_CHARSET_FARAWAY=2.45]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6QPx49oIzDGK for <mpls@ietfa.amsl.com>; Fri, 24 May 2013 05:47:39 -0700 (PDT)
Received: from asmtp2.iomartmail.com (asmtp2.iomartmail.com [62.128.201.249]) by ietfa.amsl.com (Postfix) with ESMTP id 638C821F8E8F for <mpls@ietf.org>; Fri, 24 May 2013 05:47:39 -0700 (PDT)
Received: from asmtp2.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp2.iomartmail.com (8.13.8/8.13.8) with ESMTP id r4OClTXA017013; Fri, 24 May 2013 13:47:29 +0100
Received: from 950129200 (dsl-sp-81-140-15-32.in-addr.broadbandscope.com [81.140.15.32]) (authenticated bits=0) by asmtp2.iomartmail.com (8.13.8/8.13.8) with ESMTP id r4OClQJn016991 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 24 May 2013 13:47:26 +0100
From: Adrian Farrel <adrian@olddog.co.uk>
To: "'Hejia (Jia)'" <hejia@huawei.com>, 'Loa Andersson' <loa@pi.nu>, 'Martin Vigoureux' <martin.vigoureux@alcatel-lucent.com>, draft-farbryantrel-mpls-retire-ach-tlv@tools.ietf.org, mpls-chairs@tools.ietf.org
References: <518A064C.7090006@pi.nu> <735916399E11684EAF4EB4FB376B71952C6CCBDA@SZXEML505-MBX.china.huawei.com> <040501ce57af$1d2f8570$578e9050$@olddog.co.uk> <735916399E11684EAF4EB4FB376B71952C6CCF9A@SZXEML505-MBX.china.huawei.com>
In-Reply-To: <735916399E11684EAF4EB4FB376B71952C6CCF9A@SZXEML505-MBX.china.huawei.com>
Date: Fri, 24 May 2013 13:47:22 +0100
Message-ID: <05e901ce587c$d95cf520$8c16df60$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQEA85wkIqTcvalMAOBxYkCEqrMtWQIYPP8LAbZBcX0Co20WUZp7gnnQ
Content-Language: en-gb
Cc: mpls@ietf.org
Subject: Re: [mpls] MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 May 2013 12:47:45 -0000

Got it, thanks.
Stored for next revision.
A

> -----Original Message-----
> From: Hejia (Jia) [mailto:hejia@huawei.com]
> Sent: 24 May 2013 11:57
> To: adrian@olddog.co.uk; 'Loa Andersson'; 'Martin Vigoureux';
draft-farbryantrel-
> mpls-retire-ach-tlv@tools.ietf.org; mpls-chairs@tools.ietf.org
> Cc: mpls@ietf.org
> Subject: Re: MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv
> 
> Adrian,
> 
> Thanks for your prompt response. You are so quick. I noticed you have already
> uploaded another WG version when I got time to read emails today:-)
> If possible, I guess the last sentence of the second paragraph can be more
> precise by adding "ACH" before "TLVs" which reads
> 
> " the use of ACH TLVs is undesirable."  (typo: s/in/is)
> 
> This will help to remove the impact to other TLVs used in G-ACh messages but
> not in the ACH.
> 
> Thanks!
> 
> 
> B.R.
> Jia
> 
> 
> 
> -----邮件原件-----
> 发件人: Adrian Farrel [mailto:adrian@olddog.co.uk]
> 发送时间: 2013年5月23日 20:15
> 收件人: Hejia (Jia); 'Loa Andersson'; 'Martin Vigoureux';
draft-farbryantrel-mpls-
> retire-ach-tlv@tools.ietf.org; mpls-chairs@tools.ietf.org
> 抄送: mpls@ietf.org
> 主题: RE: MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv
> 
> Thanks Jia,
> 
> Your point is well taken and the Abstract in the working copy (ready to post)
> now reads...
> 
>    The MPLS Generic Associated Channel (G-ACh) is a generalization of
>    the applicability of the Pseudowire (PW) Associated Channel Header
>    (ACH).  RFC 5586 defines the concept of TLV constructs that can be
>    carried in messages on the G-ACh by placing them in the ACH between
>    the fixed header fields and the G-ACh message.  These TLVs are called
>    ACH TLVs
> 
>    No Associated Channel Type yet defined uses an ACH TLV.  Furthermore,
>    it is believed that handling TLVs in hardware introduces significant
>    problems to the fast-path, and since G-ACh messages are intended to
>    be processed substantially in hardware, the use of TLVs in
>    undesirable.
> 
>    This document updates RFC 5586 by retiring ACH TLVs and removing the
>    associated registry.
> 
> Cheers,
> Adrian
> 
> > -----Original Message-----
> > From: Hejia (Jia) [mailto:hejia@huawei.com]
> > Sent: 23 May 2013 12:52
> > To: Loa Andersson; Martin Vigoureux; draft-farbryantrel-mpls-retire-ach-
> > tlv@tools.ietf.org; mpls-chairs@tools.ietf.org
> > Cc: mpls@ietf.org
> > Subject: Re: MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv
> >
> > Hi,
> >
> > I noticed a 01 version of draft-farbryantrel-mpls-retire-ach-tlv is
available.
> So I
> > based my MPLS RT review on that version. I think the document is coherent,
> > useful, technically sound and ready to be adopted as a WG draft. Just one
> > comment:
> >
> > 1) In the Abstract part, it is written as
> >
> >    No Associated Channel Type yet defined uses a TLV. Furthermore, it
> >    is believed that handling TLVs in hardware introduces significant
> >    problems to the fast-path, and since G-ACh messages are intended to
> >    be processed substantially in hardware, the use of TLVs in
> >    undesirable.
> >
> > The whole paragraph seems talking generally about TLVs for G-ACh messages,
> > not specifically an ACH TLV. This might not be so accurate since we have
some
> G-
> > ACh channel type using TLVs in its message, e.g. RFC 6428 defines a source
> MEP-
> > ID TLV for the MPLS-TP CV type which also requires hardware processing. I
> think
> > it might be better to simply say ACH TLV is not used and may cause
additional
> > processing which is not desirable. Or some better wording...
> >
> > Thanks!
> >
> >
> > B.R.
> > Jia
> >
> >
> > -----邮件原件-----
> > 发件人: Loa Andersson [mailto:loa@pi.nu]
> > 发送时间: 2013年5月8日 16:01
> > 收件人: Lizhong Jin; Hejia (Jia); Gregory Mirsky; Eric Osborne (eosborne);
> Martin
> > Vigoureux
> > 抄送: draft-farbryantrel-mpls-retire-ach-tlv@tools.ietf.org; mpls-
> > chairs@tools.ietf.org
> > 主题: MPLS-RT review of draft-farbryantrel-mpls-retire-ach-tlv
> >
> > Jia, Lizhong, Greg and Eric,
> >
> > You have been selected as an MPLS Review team reviewers for
> > draft-farbryantrel-mpls-retire-ach-tlv-00.
> >
> > Note to authors: You have been CC'd on this email so that you can know
> > that this review is going on. However, please do not review your own
> > document.
> >
> > Reviews should comment on whether the document is coherent, is it
> > useful (ie, is it likely to be actually useful in operational
> > networks), and is the document technically sound?  We are interested
> > in knowing whether the document is ready to be considered for WG
> > adoption (ie, it doesn't have to be perfect at this point, but should be
> > a good start).
> >
> > Reviews should be sent to the document authors, WG co-chairs and
> > WG secretary, and CC'd to the MPLS WG email list. If necessary, comments
> > may be sent privately to only the WG chairs.
> >
> > Are you able to review this draft by Mat 24, 2013?
> >
> > Thanks, Loa
> > (as MPLS WG chair)
> > --
> >
> >
> > Loa Andersson                        email: loa@mail01.huawei.com
> > Senior MPLS Expert                          loa@pi.nu
> > Huawei Technologies (consultant)     phone: +46 739 81 21 64