Re: [mpls] RtgDir review: draft-ietf-mpls-targeted-mldp-03.txt
Lizhong Jin <lizho.jin@gmail.com> Thu, 05 September 2013 02:06 UTC
Return-Path: <lizho.jin@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 85FB711E8237; Wed, 4 Sep 2013 19:06:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599, HTML_MESSAGE=0.001, NO_RELAYS=-0.001]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bk0RWSUMX4Bi; Wed, 4 Sep 2013 19:06:32 -0700 (PDT)
Received: from mail-qe0-x22b.google.com (mail-qe0-x22b.google.com [IPv6:2607:f8b0:400d:c02::22b]) by ietfa.amsl.com (Postfix) with ESMTP id 50D0711E8155; Wed, 4 Sep 2013 19:06:32 -0700 (PDT)
Received: by mail-qe0-f43.google.com with SMTP id gh4so642128qeb.2 for <multiple recipients>; Wed, 04 Sep 2013 19:06:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=OuuLprFv+Vx8NujXMpcj2Qs1eOll5oRoSdPMToKkRkg=; b=ETApS8iHdc7qMIPDvScSWudzi9Yy3bECoqWWD8RE3BLuoR5SRidIp9ayixviJWA9vi pJsqiV1WPad26R20sQKkQ29R/EKzg+pMDfzzJ+KYcJSrojQ887gsrZOowoWZXnfkR+EU IzKj4aLFqZ+wmzXfdj1m3R/Rfadp7qTv76ZTKIOo2dZ9JeUN0YhQ8eWRW5Qhh5ZRJpnw CPzvUhr8Pw1FkGi5jmc8viwMjiuCsCqfMVg0yXwexzz6J+RLZKuVwLWKGXgH/ZiiKhT9 5uujw5SXQtR0cJgKbfsJkK+Mb8LCWQicwbd40nmVW+sIU2tXQ2pEB1UVyr3W2pZipopq V97Q==
MIME-Version: 1.0
X-Received: by 10.229.185.68 with SMTP id cn4mr7041215qcb.5.1378346791794; Wed, 04 Sep 2013 19:06:31 -0700 (PDT)
Received: by 10.49.3.225 with HTTP; Wed, 4 Sep 2013 19:06:31 -0700 (PDT)
Date: Thu, 05 Sep 2013 10:06:31 +0800
Message-ID: <CAH==cJx6id9jStc_w72T85h5Z6knh6GDeYR72wYEVRh0ht_zLA@mail.gmail.com>
From: Lizhong Jin <lizho.jin@gmail.com>
To: erosen@cisco.com
Content-Type: multipart/alternative; boundary="001a1134a474e6fc9504e5995ee2"
Cc: rtg-dir@ietf.org, draft-ietf-mpls-targeted-mldp.all@tools.ietf.org, "mpls@ietf.org" <mpls@ietf.org>, rtg-ads@tools.ietf.org
Subject: Re: [mpls] RtgDir review: draft-ietf-mpls-targeted-mldp-03.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Sep 2013 02:06:33 -0000
Hi Eric, I am OK with all your reply and clarification. Thanks Lizhong On Thu, Sep 5, 2013 at 12:09 AM, Eric Rosen <erosen@cisco.com> wrote: > Thank you for taking a close look at this draft again. > [Lizhong] my pleasure to reivew again. :) > > > 1. Section 1 is introduction, but section 1.2, 1.3, 1.4 seem to define > the > > specification, not overview introduction. It is suggest to have a > separate > > section to describe the introduction. > > Fair enough. Sections 1.2, 1.3, and 1.4 will be "promoted" to sections 2, > 3, and 4 respectively, leaving the old section 1.1 as the introduction. > [Lizhong] good. > > > 2. Section 1.1, the reference of mLDP RFC is indexed by [mLDP], not > > [RFC6388] (same for [LDP-UP]). I am not quite sure IETF template allows > > this, please check > > This style of cross-reference is very commonly used. > [Lizhong] I am OK now. > > > 3. Section 1.2.1, line 176, what if there is IGP neighbors, and there is > > targeted LDP session between U and D? This is possible in some > > deployments. > > The cited text: > > - U is the "BGP next hop" on D's path to R, where U and D are not > IGP neighbors, and where there is a Targeted LDP session between > U and D. In this case, we allow D to select U as the "upstream > LSR" for <R,X>. > > suggests that the targeted session cannot be used in this case. Probably > it > is best to leave the handling of this case as a choice for the SP, so I > will > change it to ""where U and D are not necessarily IGP neighbors". This > would > allow the targeted session to be used if so chosen. > [Lizhong] I am OK now. > > > 4. Section 1.2.1, line 188, is there a precedence among the different > > methods, and the operator could define the precedence? > > I think it is best to just say (as it does) "the method is chosen by > provisioning". Whether it is possible for an operator to configure an > ordered list of methods to try is a local matter (i.e., doesn't have to be > specified in the RFC). > [Lizhong] OK now. > > > 5. Section 3, line 356, how does D know to send label request, not label > > mapping message? Multicast or unicast from U to D is determined by U, and > > D could not get this information automatically. Then is there any static > > configuration required here? > > As stated in section 1.3 (section 3 in the next revision): > > "the choice between unicast replication and multicast tunneling is > determined by provisioning, or by other methods that are outside the > scope of this specification. It is presupposed that all nodes will have > a priori knowledge of whether to use unicast replication or to use > multicast tunneling. If the latter, it is presupposed that all nodes > will have a priori knowledge of the type of multicast tunneling to use." > [Lizhong] OK, I missed this. > > > 6. Section 3, line 358, the label request messages mentioned in the text > > should be upstream label request message. It is better to explicit to say > > this. > > I'll add that D1 and D2 follow the procedures of Section 4 of [LDP-UP] when > requesting U to assign the label. > [Lizhong] OK. > > > 7. Section 3, line 382, it is said: While it is possible to do this, it > is > > highly RECOMMENDED that MP2MP LSPs be tunneled through MP2MP LSPs. I do > > not quite understand this statement. This specification does not describe > > the mechanism of MP2MP LSPs being tunneled through MP2MP LSPs. From my > > view, MP2MP LSPs over MP2MP LSPs is not easy, and should resolve the > > upstream label uniqueness among different upstream nodes. It should be > > caution to have this recommendations here. > > Perhaps it would be best just to say: > > Procedures for tunneling MP2MP LSPs through P2MP or MP2MP LSPs are > outside the scope of this document. > > [Lizhong] Agree