Re: [mpls] MPLS-RT review of draft-bonica-mpls-self-ping

"lizho.jin@gmail.com" <lizho.jin@gmail.com> Tue, 10 March 2015 16:21 UTC

Return-Path: <lizho.jin@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B44311A1B86 for <mpls@ietfa.amsl.com>; Tue, 10 Mar 2015 09:21:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wfNhsVm4LPVA for <mpls@ietfa.amsl.com>; Tue, 10 Mar 2015 09:21:54 -0700 (PDT)
Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 926881A003A for <mpls@ietf.org>; Tue, 10 Mar 2015 09:21:54 -0700 (PDT)
Received: by oiax69 with SMTP id x69so2529587oia.5 for <mpls@ietf.org>; Tue, 10 Mar 2015 09:21:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:references:mime-version:message-id :content-type; bh=aXzMGTBgKag43XMmub6l2D3gi4jJIWuB+lbQ/m7f7yk=; b=wiDBENFvnzakWL6zCeezWaUz2SVF8vv3RYRqry7q1lyBAgBdk3c8StOiIzvQfkAyVQ xBZrMjILe9//JCd3++EWGnBZtVqa0tHv9DvdRSCffSWW2/3wt9ugrfpmW6S9qrHy/diI xdm5KDde7p6EuTaoNZeXqbnPb6XBnhy3lX8MDuzXyj6jIYWK6r2PxU0NDZtCsi4pqgZw lqH8Z3qDAuA2aJnfABD/39ewxVt1tatSnswwsPB2cYVaIlaxiPhKWzWn3Izt60sKQr2V hmzgucQz9Twz4HazFfxzFpqoBokhIbpxO2CgAy+XAEt0IoJYb/6hSnQX0Qz9uV9Oi2+Z 6dJA==
X-Received: by 10.107.30.135 with SMTP id e129mr58844425ioe.26.1426004513954; Tue, 10 Mar 2015 09:21:53 -0700 (PDT)
Received: from Lizhong ([118.132.235.56]) by mx.google.com with ESMTPSA id e196sm710320ioe.40.2015.03.10.09.21.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2015 09:21:52 -0700 (PDT)
Date: Wed, 11 Mar 2015 00:22:10 +0800
From: "lizho.jin@gmail.com" <lizho.jin@gmail.com>
To: mpls-chairs <mpls-chairs@tools.ietf.org>, draft-bonica-mpls-self-ping <draft-bonica-mpls-self-ping@tools.ietf.org>, mpls-ads <mpls-ads@tools.ietf.org>
References: <54EC4776.5040402@pi.nu>
X-Priority: 3
X-GUID: 72A9A112-F484-4CBF-8DD1-5EB9456CFBE0
X-Has-Attach: no
X-Mailer: Foxmail 7, 2, 5, 140[en]
Mime-Version: 1.0
Message-ID: <2015031100220789189743@gmail.com>
Content-Type: multipart/alternative; boundary="----=_001_NextPart467810452515_=----"
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/XeChCNa_28-anEXSD7VqsN-JVb8>
Cc: mpls <mpls@ietf.org>
Subject: Re: [mpls] MPLS-RT review of draft-bonica-mpls-self-ping
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Mar 2015 16:21:56 -0000

Hi authors,
I finish the MPLS-RT review for draft-bonica-mpls-self-04, and the document is clearly written.
The self-ping is useful in a normal network scenarios, and also will not work if uRPF is enabled on the egress. But there are more scenarios where self-ping will fail as below:
1. If one transite node wrongly installs a output lable as implicit null, then the self-ping reply message will be sent back by the next node. Then the ingress node will verify that the RSVP-TE LSP is OK, but the fact is the LSP is broken. That is self-ping could not detect the LSP down because of wrong label installation. 
2. In the network with link aggregation or other load balance mechanism, the self-ping may also provide wrong LSP validation information, but LSP Ping could support that scenario.
3. Reply message may not be able to route back to the ingress if the ingress IP address is not directly IP reachable for the egress node.
It is better to describe all fail scenarios in an independent section, like section 4. It should be highlighted to the reader.

For section 6, originally ingress could identify the LSP ping packet with well-known UDP port, and configure ACL rule to reduce risk of attack. But now it is more difficult to filter the packet with access list, which may increase the risk.

Overall, I have some concern with the tool of self-ping, especally to this fail scenarios. Let's assume ingress node receives the RESV message from downstream, then do self-ping, then:
1. if success, you are not ensured that the LSP is really OK.
2. if fail, you still have to use LSP Ping again.



Regards
Lizhong
 
From: Loa Andersson
Date: 2015-02-24 17:42
To: Carlos Pignataro (cpignata); Gregory Mirsky; Mach Chen; Lizhong Jin; mpls-chairs@tools.ietf.org; draft-bonica-mpls-self-ping@tools.ietf.org; <mpls-ads@tools.ietf.org>
Subject: MPLS-RT review of draft-bonica-mpls-self-ping
Carlos, Greg, Mach and Lizhong,
 
You have be selected as MPLS-RT reviewers for draft-bonica-mpls-self-
ping-04.
 
Note to authors: You have been CC'd on this email so that you can know
that this review is going on. However, please do not review your own
document.
 
Reviews should comment on whether the document is coherent, is it
useful (ie, is it likely to be actually useful in operational
networks), and is the document technically sound?  We are interested
in knowing whether the document is ready to be considered for WG
adoption (ie, it doesn't have to be perfect at this point, but should be
a good start).
 
Reviews should be sent to the document authors, WG co-chairs and
WG secretary, and CC'd to the MPLS WG email list. If necessary, comments
may be sent privately to only the WG chairs.
 
If you have technical comments you should try to be explicit about what
*really* need to be resolved before adopting it as a working group
document, and what can wait until the document is a working group
document and the working group has the revision control.
 
Are you able to review this draft by Mar 11, 2015? Please respond in a
timely fashion.
 
 
Thanks, Loa
(as MPLS WG chair)
-- 
 
 
Loa Andersson                        email: loa@mail01.huawei.com
Senior MPLS Expert                          loa@pi.nu
Huawei Technologies (consultant)     phone: +46 739 81 21 64