Re: [mpls] Warren Kumari's No Objection on draft-ietf-mpls-spring-entropy-label-11: (with COMMENT)

Warren Kumari <warren@kumari.net> Fri, 06 July 2018 16:33 UTC

Return-Path: <warren@kumari.net>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E439130EEB for <mpls@ietfa.amsl.com>; Fri, 6 Jul 2018 09:33:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=kumari-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6l82i-BufOfF for <mpls@ietfa.amsl.com>; Fri, 6 Jul 2018 09:33:07 -0700 (PDT)
Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1E9C8130ED1 for <mpls@ietf.org>; Fri, 6 Jul 2018 09:33:05 -0700 (PDT)
Received: by mail-wm0-x242.google.com with SMTP id s13-v6so4855374wmc.1 for <mpls@ietf.org>; Fri, 06 Jul 2018 09:33:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kumari-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cv/9WV84Gql8G0o7pk8eSRFLEYMImCvWupR2Ba6ow1s=; b=lgG7GTlanoXmcX3SwYHKWHJ4L7k9lWocw5OKgbuLjdX8RRTJV8BEYCptKBFlCabwUA fU/ylpB3YJoGCQ8qoUS96nIO+KFn69WYgwsQjWNZQtGPHwJeDEKWFEr4L9JBPBnemix4 ddALWNtmxf8NcapzfNBId6LUdAYqkst7UYjKH+urrm/BouiQ62FLwmcB6kgrLAxKTIu2 a6a3inRJ1D//sUsvDYeeB1KmjblXFfcUJi0nFakFvsRJMMRYCsuhuLIsG0UVzBbWWhMp 9rE11UKUDMxlFS4YGN9A0O2DV6HJvXHlPevFiX1KR46C815xHnRleQSYaCjy4X17p7uH 98xA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cv/9WV84Gql8G0o7pk8eSRFLEYMImCvWupR2Ba6ow1s=; b=mLvbtvyGZGJqr5x0IXUjh5OUhK1J2UZ+OrELQDiwMQI8Qb8TMigU0+swbUmXCYQrJK xStcACskM+cDeY6xglZ9piU7mjHhCDAriRK7sVLTCGbKKdqFY6j5tZrFhI+lNxtdUczg dDtkQvfQalhLOoqGRQJs5AXFihnxI8d+7nVnq7wlSDSP+gZXcYJVNNcDoShmVS/YmjdP 3/dhnsU4b3HD5M2+AdMB6OGRNY6nPdNZSgRK+uo88pM/D23jKbqsq6PH0dAdvruBkNoG WxlXAjm6z5WbfbNZ9OPYcXOePR3E29tlXw5yfzIqjtGIVqpRTQbJoTKBNqX6iyVO7s7W 9KDw==
X-Gm-Message-State: APt69E2PZstw4Yn08z0uXHPajYN9vKdtbjvdgsGyFbbmK+jI2VbWqDTl Hj8bO6UqDhBfBxvLut5wFvDMaZxaBEFhF43KIyW5jQ==
X-Google-Smtp-Source: AAOMgpfrZs2gfiN779P11g3hyHHvPvVoy4JujTvbIJW5lgD5jhZbJUUCii+9c5KWT6iR3r45Van8i7QsFOHaEg+ZGbQ=
X-Received: by 2002:a1c:8b0d:: with SMTP id n13-v6mr6468531wmd.46.1530894783300; Fri, 06 Jul 2018 09:33:03 -0700 (PDT)
MIME-Version: 1.0
References: <153072742469.27345.10568037891590813544.idtracker@ietfa.amsl.com> <23533_1530791022_5B3E046E_23533_427_1_9E32478DFA9976438E7A22F69B08FF924B1EFCBA@OPEXCLILMA4.corporate.adroot.infra.ftgroup> <CAHw9_i+9t+wG7aQPgNRtzBqOgiwU2K3=PjmJY57Ts==1rPtvzA@mail.gmail.com> <20117_1530832141_5B3EA50C_20117_94_1_9E32478DFA9976438E7A22F69B08FF924B1F01E1@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
In-Reply-To: <20117_1530832141_5B3EA50C_20117_94_1_9E32478DFA9976438E7A22F69B08FF924B1F01E1@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
From: Warren Kumari <warren@kumari.net>
Date: Fri, 06 Jul 2018 12:32:27 -0400
Message-ID: <CAHw9_iKjS63bO533N5Kicz93FkcrBqZSJu7-xcFwVnZAVBOCxA@mail.gmail.com>
To: stephane.litkowski@orange.com
Cc: The IESG <iesg@ietf.org>, draft-ietf-mpls-spring-entropy-label@ietf.org, mpls@ietf.org, "BRUNGARD, DEBORAH A" <db3546@att.com>, mpls-chairs@ietf.org, Loa Andersson <loa@pi.nu>, Joe Clarke <jclarke@cisco.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/ca2PeV20Z3dwngIn2YgbfM_R-vE>
Subject: Re: [mpls] Warren Kumari's No Objection on draft-ietf-mpls-spring-entropy-label-11: (with COMMENT)
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 16:33:10 -0000

On Thu, Jul 5, 2018 at 7:09 PM <stephane.litkowski@orange.com> wrote:
>
> I have added the following text:
>
> “There may also be a case where a router has a fast switching path (handled by an ASIC or network processor) and a slow switching path (handled by a CPU) with a different ERLD for each switching path. Again, for simplicity reasons, an implementation MAY use the minimum ERLD as the ERLD value for the system.”
>
>
>
> I have also highlighted the drawback as per Joe’s comment:
>
> “The drawback of using a single ERLD for a system lower than the capability of one or more specific component is that it may increase the number of ELI/ELs inserted. This leads to an increase of the label stack size and may have an impact on the capability of the ingress node to push this label stack.”
>
>

Awesome, thank you - nicely worded, and works for me.
W

>
>
>
> From: Warren Kumari [mailto:warren@kumari.net]
> Sent: Thursday, July 05, 2018 17:08
> To: LITKOWSKI Stephane OBS/OINIS
> Cc: The IESG; draft-ietf-mpls-spring-entropy-label@ietf.org; mpls@ietf.org; BRUNGARD, DEBORAH A; mpls-chairs@ietf.org; Loa Andersson; Joe Clarke
> Subject: Re: Warren Kumari's No Objection on draft-ietf-mpls-spring-entropy-label-11: (with COMMENT)
>
>
>
>
>
>
>
> On Thu, Jul 5, 2018 at 7:43 AM <stephane.litkowski@orange.com> wrote:
>
> Thanks Warren,
>
> I agree with your comments and I will address them in the next revision.
>
>
>
> Thanks!
>
>
>
>
>
> You are right (at least from a theoretical point of view) about fast path vs slow path for ERLD. I think for this kind of switching implementation, we have several options: advertising the fast path ERLD (slow path will never be triggered), advertising the slow path ERLD (there is a possibility that slow path will be triggered for each packet), let this configurable by the user. I do not think that this fast path/slow path implementation is still popular at least for the SP router market.
>
>
>
> I'm fine with whatever you select, I just wanted it to be considered.
>
> W
>
>
>
>
>
> -----Original Message-----
> From: Warren Kumari [mailto:warren@kumari.net]
> Sent: Wednesday, July 04, 2018 20:04
> To: The IESG
> Cc: draft-ietf-mpls-spring-entropy-label@ietf.org; mpls@ietf.org; db3546@att.com; draft-ietf-mpls-spring-entropy-label@ietf.org; mpls-chairs@ietf.org; loa@pi.nu; mpls@ietf.org; jclarke@cisco.com
> Subject: Warren Kumari's No Objection on draft-ietf-mpls-spring-entropy-label-11: (with COMMENT)
>
> Warren Kumari has entered the following ballot position for
> draft-ietf-mpls-spring-entropy-label-11: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-mpls-spring-entropy-label/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Thank you for writing this - it provides useful functionality.
>
> Please see Joe Clarke's OpsDir review here:
> https://datatracker.ietf.org/doc/review-ietf-mpls-spring-entropy-label-11-opsdir-lc-clarke-2018-06-25/
>  - it mirrors comments made by a number of ADs, and also contains a significnat
> number of nits (which would make the document better / more readable).
>
> I had a question:
> Section 4.  Entropy Readable Label Depth
> " The Entropy Readable Label Depth (ERLD) is defined as the number of
>    labels a router can both:
>    a.  Read in an MPLS packet received on its incoming interface(s)
>        (starting from the top of the stack).
>    b.  Use in its load-balancing function."
> ...
> "In a distributed switching architecture, each linecard may have a different
> capability in terms of ERLD."
>
> In many cases, a device may have a different readable label depth in hardware /
> fastpath than it does by punting the packet to the CPU / control plane. Perhaps
> the ERLD should be defined as 'Use in its load-balancing function in the
> dataplace / fast-path" (or something, this will need some wording).
>
> I'd also like to say that I like Section 10 (Options considered) - sections
> like this make a document much more satisfying (otherwise one has niggling
> questions like "What didn't they do single ELs at the bottom of the stack?!") -
> thank you for including it.
>
> I also have some nits:
> Section 1.  Introduction
> "The hashing technique is required to perfom a per-flow load-balancing and thus
> prevent packet disordering. " 1: Perform is a type 2: While 'disordering'
> explains it well, 'reordering' is a much more common term, and will (I think)
> cause less confusion.
>
> "The MPLS architecture brings some challenges on the load-balancing as an LSR
> (Label Switch Router) should be able to look at header fields that are beyond
> the MPLS label stack." "on the load-balancing" doesn't really parse. Perhaps:
> "... brings some load-balancing challenges, as..."?
>
> Section 2.  Abbreviations and Terminology
> SRGB is not defined on first use, nor it is in the Terminology section. Also,
> sorting this alphabetically would be appreciated.
>
>
>
> _________________________________________________________________________________________________________________________
>
> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
>
> This message and its attachments may contain confidential or privileged information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
> Thank you.
>
>
>
>
> --
>
> I don't think the execution is relevant when it was obviously a bad idea in the first place.
> This is like putting rabid weasels in your pants, and later expressing regret at having chosen those particular rabid weasels and that pair of pants.
>    ---maf
>
> _________________________________________________________________________________________________________________________
>
> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
>
> This message and its attachments may contain confidential or privileged information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
> Thank you.



-- 
I don't think the execution is relevant when it was obviously a bad
idea in the first place.
This is like putting rabid weasels in your pants, and later expressing
regret at having chosen those particular rabid weasels and that pair
of pants.
   ---maf