Re: [mpls] Warren Kumari's No Objection on draft-ietf-mpls-spring-entropy-label-11: (with COMMENT)

Warren Kumari <warren@kumari.net> Thu, 05 July 2018 15:08 UTC

Return-Path: <warren@kumari.net>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B9CF2130EDE for <mpls@ietfa.amsl.com>; Thu, 5 Jul 2018 08:08:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=kumari-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cuB4ZUz1OFAO for <mpls@ietfa.amsl.com>; Thu, 5 Jul 2018 08:08:40 -0700 (PDT)
Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 01197130F0F for <mpls@ietf.org>; Thu, 5 Jul 2018 08:08:27 -0700 (PDT)
Received: by mail-wr1-x42f.google.com with SMTP id h10-v6so1365552wrq.8 for <mpls@ietf.org>; Thu, 05 Jul 2018 08:08:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kumari-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aPDqYRf8/aOIDl+saCtmWoMUbSzANGYyEW8tyUIs7uc=; b=SJMLNopA6ftsVqyup71Ulb+8UU/W9LN/p9+wtPLPpZsKeA7MGs3LSK9L/m0fkpM3c2 /SQUw7MOBynGml+CNj9R1kWth8cwF5+6G4Ncoia3RPACSMDCOnBOG+6/qTqT4ywaZizX JHPgOWbQG582/mucWW11nlc3PI5uUSjBelCsRXPCzg7oxHgRF56NsTbdiKEQ29xj+5rQ W+QSSEZRxCS/9zWSRrdlT+xQHp7NGSIaYwdmdavawWI8Wi9dX06k7h974Y7XWX3OlCBJ 4iLGEwLGnykC5f3VjwHwrKNXqWDq8MvVxN5xCgjKlRzBtW7friRvP27kDSEheC858/tk voKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aPDqYRf8/aOIDl+saCtmWoMUbSzANGYyEW8tyUIs7uc=; b=ZCvrHwHQ0SOMZYQybwOJvBFgzA6sjjfNnkNgdz/aJmQ2Dne8TZ7ZuuVEB6+iXqiYHq ppxtnaFSvvIXYnCfCK6kcnOZSnwVQTkP9wUdamob8cs8HyWduFNlYV+Mx2YqMkycXc0V XAiGwuJ2TEqoS0cfQqe7Q46A62JnDIqDbkx5snzmc555A2ANKJ118lul6fFO+cxMQqFE phiuZcMUZjuVgHSsBiZX1s5Ujqy0uhj0Qyrop74c1luHZWDjnLFPmJyv1Uj+jz16dVwq czH0nZOKGQloio71xeBTHXCJ6URpc7NevS+EU+umzyn+HYql4yqCKcYYJVJO8zt6h8Af yGcg==
X-Gm-Message-State: APt69E0jsyZ9OSXT0R+nfiRIwz+80BHh3NlgR5WMgktDkEdS/7aj3Y87 xeafKhiEFqv4bJXXa99O3LeTfSZmZqOaw5GO+1J2oQ==
X-Google-Smtp-Source: AAOMgpdFqj2Jd36TuT/EJtLQYHwjIYXEV2Q7siatfR4/CJUbdXY+UYK0JIBjkgRVCihMy82N0r2hWBZxj3lqrEYsRX0=
X-Received: by 2002:adf:ba01:: with SMTP id o1-v6mr5153578wrg.249.1530803305838; Thu, 05 Jul 2018 08:08:25 -0700 (PDT)
MIME-Version: 1.0
References: <153072742469.27345.10568037891590813544.idtracker@ietfa.amsl.com> <23533_1530791022_5B3E046E_23533_427_1_9E32478DFA9976438E7A22F69B08FF924B1EFCBA@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
In-Reply-To: <23533_1530791022_5B3E046E_23533_427_1_9E32478DFA9976438E7A22F69B08FF924B1EFCBA@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
From: Warren Kumari <warren@kumari.net>
Date: Thu, 05 Jul 2018 11:07:49 -0400
Message-ID: <CAHw9_i+9t+wG7aQPgNRtzBqOgiwU2K3=PjmJY57Ts==1rPtvzA@mail.gmail.com>
To: stephane.litkowski@orange.com
Cc: The IESG <iesg@ietf.org>, draft-ietf-mpls-spring-entropy-label@ietf.org, mpls@ietf.org, "BRUNGARD, DEBORAH A" <db3546@att.com>, mpls-chairs@ietf.org, Loa Andersson <loa@pi.nu>, Joe Clarke <jclarke@cisco.com>
Content-Type: multipart/alternative; boundary="000000000000443c21057041eb9c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/_iGbsDOG50Vw8Yx5Bkxsd9eOPCY>
Subject: Re: [mpls] Warren Kumari's No Objection on draft-ietf-mpls-spring-entropy-label-11: (with COMMENT)
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jul 2018 15:08:46 -0000

On Thu, Jul 5, 2018 at 7:43 AM <stephane.litkowski@orange.com> wrote:

> Thanks Warren,
>
> I agree with your comments and I will address them in the next revision.
>

​Thanks!​



> You are right (at least from a theoretical point of view) about fast path
> vs slow path for ERLD. I think for this kind of switching implementation,
> we have several options: advertising the fast path ERLD (slow path will
> never be triggered), advertising the slow path ERLD (there is a possibility
> that slow path will be triggered for each packet), let this configurable by
> the user. I do not think that this fast path/slow path implementation is
> still popular at least for the SP router market.
>
>
​I'm fine with whatever you select, I just wanted it to be considered.​
W



> -----Original Message-----
> From: Warren Kumari [mailto:warren@kumari.net]
> Sent: Wednesday, July 04, 2018 20:04
> To: The IESG
> Cc: draft-ietf-mpls-spring-entropy-label@ietf.org; mpls@ietf.org;
> db3546@att.com; draft-ietf-mpls-spring-entropy-label@ietf.org;
> mpls-chairs@ietf.org; loa@pi.nu; mpls@ietf.org; jclarke@cisco.com
> Subject: Warren Kumari's No Objection on
> draft-ietf-mpls-spring-entropy-label-11: (with COMMENT)
>
> Warren Kumari has entered the following ballot position for
> draft-ietf-mpls-spring-entropy-label-11: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-mpls-spring-entropy-label/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Thank you for writing this - it provides useful functionality.
>
> Please see Joe Clarke's OpsDir review here:
>
> https://datatracker.ietf.org/doc/review-ietf-mpls-spring-entropy-label-11-opsdir-lc-clarke-2018-06-25/
>  - it mirrors comments made by a number of ADs, and also contains a
> significnat
> number of nits (which would make the document better / more readable).
>
> I had a question:
> Section 4.  Entropy Readable Label Depth
> " The Entropy Readable Label Depth (ERLD) is defined as the number of
>    labels a router can both:
>    a.  Read in an MPLS packet received on its incoming interface(s)
>        (starting from the top of the stack).
>    b.  Use in its load-balancing function."
> ...
> "In a distributed switching architecture, each linecard may have a
> different
> capability in terms of ERLD."
>
> In many cases, a device may have a different readable label depth in
> hardware /
> fastpath than it does by punting the packet to the CPU / control plane.
> Perhaps
> the ERLD should be defined as 'Use in its load-balancing function in the
> dataplace / fast-path" (or something, this will need some wording).
>
> I'd also like to say that I like Section 10 (Options considered) - sections
> like this make a document much more satisfying (otherwise one has niggling
> questions like "What didn't they do single ELs at the bottom of the
> stack?!") -
> thank you for including it.
>
> I also have some nits:
> Section 1.  Introduction
> "The hashing technique is required to perfom a per-flow load-balancing and
> thus
> prevent packet disordering. " 1: Perform is a type 2: While 'disordering'
> explains it well, 'reordering' is a much more common term, and will (I
> think)
> cause less confusion.
>
> "The MPLS architecture brings some challenges on the load-balancing as an
> LSR
> (Label Switch Router) should be able to look at header fields that are
> beyond
> the MPLS label stack." "on the load-balancing" doesn't really parse.
> Perhaps:
> "... brings some load-balancing challenges, as..."?
>
> Section 2.  Abbreviations and Terminology
> SRGB is not defined on first use, nor it is in the Terminology section.
> Also,
> sorting this alphabetically would be appreciated.
>
>
>
>
> _________________________________________________________________________________________________________________________
>
> Ce message et ses pieces jointes peuvent contenir des informations
> confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez
> recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
> electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou
> falsifie. Merci.
>
> This message and its attachments may contain confidential or privileged
> information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and
> delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been
> modified, changed or falsified.
> Thank you.
>
>

-- 
I don't think the execution is relevant when it was obviously a bad idea in
the first place.
This is like putting rabid weasels in your pants, and later expressing
regret at having chosen those particular rabid weasels and that pair of
pants.
   ---maf