Re: [mpls] MIB Dr. review of draft-ietf-tp-linear-mib-09

"Ryoo, Jeong-dong " <ryoo@etri.re.kr> Wed, 19 October 2016 07:44 UTC

Return-Path: <ryoo@etri.re.kr>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2F65C1293E1; Wed, 19 Oct 2016 00:44:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.331
X-Spam-Level:
X-Spam-Status: No, score=-102.331 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RP_MATCHES_RCVD=-0.431, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CvyvktNHJzBT; Wed, 19 Oct 2016 00:44:19 -0700 (PDT)
Received: from smtpeg.etri.re.kr (smtpeg2.etri.re.kr [129.254.27.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 56B83129533; Wed, 19 Oct 2016 00:44:18 -0700 (PDT)
Received: from SMTP1.etri.info (129.254.28.71) by SMTPEG2.etri.info (129.254.27.142) with Microsoft SMTP Server (TLS) id 14.1.355.2; Wed, 19 Oct 2016 16:44:17 +0900
Received: from SMTP2.etri.info ([169.254.2.208]) by SMTP1.etri.info ([10.2.6.30]) with mapi id 14.01.0355.002; Wed, 19 Oct 2016 16:44:14 +0900
From: "Ryoo, Jeong-dong " <ryoo@etri.re.kr>
To: Joan Cucchiara <jcucchiara.ietf@gmail.com>
Thread-Topic: MIB Dr. review of draft-ietf-tp-linear-mib-09
Thread-Index: AQHSIP5e0riTaryqu0uz9sjSdO93caCk5brDgAgacICAAnOnfw==
Date: Wed, 19 Oct 2016 07:44:14 +0000
Message-ID: <5B4A6CBE3924BB41A3BEE462A8E0B75A29223EC5@SMTP2.etri.info>
References: <CANSkkOmk8+DP-daKiDMWBsTGOw-AG8NvJ+7kNc8RNwdVLOE_uA@mail.gmail.com> <5B4A6CBE3924BB41A3BEE462A8E0B75A29221AAD@SMTP2.etri.info>, <CANSkkO=TCDTQsO1zeF2DLhdCpM0yFT3q2Ep+ah=8XHVsz8s2nA@mail.gmail.com>
In-Reply-To: <CANSkkO=TCDTQsO1zeF2DLhdCpM0yFT3q2Ep+ah=8XHVsz8s2nA@mail.gmail.com>
Accept-Language: ko-KR, en-US
Content-Language: ko-KR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-new-displayname: UnlvbywgSmVvbmctZG9uZyA=
x-originating-ip: [129.254.28.42]
Content-Type: multipart/alternative; boundary="_000_5B4A6CBE3924BB41A3BEE462A8E0B75A29223EC5SMTP2etriinfo_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/wPWngMOdQeUW9TlrM0cKSiiI_5M>
Cc: "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-mpls-tp-linear-protection-mib@ietf.org" <draft-ietf-mpls-tp-linear-protection-mib@ietf.org>, "mib-doctors@ietf.org" <mib-doctors@ietf.org>, "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, Benoit Claise <bclaise@cisco.com>
Subject: Re: [mpls] MIB Dr. review of draft-ietf-tp-linear-mib-09
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Oct 2016 07:44:22 -0000

Joan,


Thank you so much for your work on this.

The document has been greatly improved through your review and comments in the previous revisions.


Best regards,


Jeong-dong









________________________________
보낸 사람 : "Joan Cucchiara" <jcucchiara.ietf@gmail.com>
보낸 날짜 : 2016-10-18 12:05:52 ( +09:00 )
받는 사람 : 류정동 <ryoo@etri.re.kr>
참조 : Loa Andersson <loa@pi.nu>, mpls@ietf.org <mpls@ietf.org>, draft-ietf-mpls-tp-linear-protection-mib@ietf.org <draft-ietf-mpls-tp-linear-protection-mib@ietf.org>, mpls-chairs@ietf.org <mpls-chairs@ietf.org>, mib-doctors@ietf.org <mib-doctors@ietf.org>, Benoit Claise <bclaise@cisco.com>
제목 : Re: 회신: MIB Dr. review of draft-ietf-tp-linear-mib-09



Jeong-dong,





Thank you for the quick turn-around and also for the thoroughness of addressing this last round of comments.   I believe the MIB review is complete.





Thanks again for all your time and effort during this process,



-Joan







On Wed, Oct 12, 2016 at 10:29 AM, 류정동 <ryoo@etri.re.kr<mailto:ryoo@etri.re.kr>> wrote:



Dear Joan,





Thank you so much for your review and comments.



All your comments had been incorporated into the revision posted a few minutes ago as follows.





Name:           draft-ietf-mpls-tp-linear-protection-mib



Revision:       10



Title:          MPLS Transport Profile Linear Protection MIB



Document date:  2016-10-12



Group:          mpls



Pages:          45



URL:            https://www.ietf.org/internet-drafts/draft-ietf-mpls-tp-linear-protection-mib-10.txt



Status:         https://datatracker.ietf.org/doc/draft-ietf-mpls-tp-linear-protection-mib/



Htmlized:       https://tools.ietf.org/html/draft-ietf-mpls-tp-linear-protection-mib-10



Diff:           https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-tp-linear-protection-mib-10





Would you please let us know if you have any further comments on this document at your earliest convenience?





Best reagrds,





Jeong-dong









________________________________________



보낸 사람: Joan Cucchiara [jcucchiara.ietf@gmail.com<mailto:jcucchiara.ietf@gmail.com>]



보낸 날짜: 2016년 10월 8일 토요일 오전 9:53



받는 사람: Loa Andersson; mpls@ietf.org<mailto:mpls@ietf.org>; draft-ietf-mpls-tp-linear-protection-mib@ietf.org<mailto:draft-ietf-mpls-tp-linear-protection-mib@ietf.org>; mpls-chairs@ietf.org<mailto:mpls-chairs@ietf.org>; mib-doctors@ietf.org<mailto:mib-doctors@ietf.org>



참조: 류정동; Benoit Claise



제목: MIB Dr. review of draft-ietf-tp-linear-mib-09





Authors,





Thank you for addressing the comments so thoroughly, and especially for



clarifying the example in section 7.    Much appreciated.





The MIB compiles with smilint and smicngPRO.   Comments are below.





Thank you,



-Joan





Comments:



----------------





1) Section 6.1 Relationship to the MPLS OAM Maintenance Identifiers MIB Module





   "The mplsLpsMeConfigTable entry is extended by the entry in the



   mplsOamIdMeTable defined in [RFC7697]."





The above statement is backwards....think the intention is to say something like:



Entries in the mplsOamIdMeTable [RFC7697] are extended by entries in the mplsLspMeConfigTable.





2) later in this same section, section 6.1





   "An entry of this table is related to a single entry in mplsOamIdMeTable."





The above is confusing because you've already discuss the sparse augments relationship.  Please remove



the above sentence.







MIB Module



------------



3)  mplsLpsConfigIndexNext  -   please rename to mplsLpsConfigDomainIndexNext.



Since this scalar is only used for the mplsLpsConfigDomainIndex index's values, the name should reflect that.



NOTE:  this name change should be propagated elsewhere in the draft.  Please do a search and replace.





4) mplsLpsConfigDomainIndex  (editorial)



  "Managers should..."





s/Managers/Operators/







5) mplsLpsConfigCommand



Why is there NO DEVAL?   Wouldn't "noCmd" be an appropriate DEFVAL?







6) mplsLpsConfigRowStatus DESCRIPTION clause





RowStatus objects reflect the status of the Row, not a determination of whether or not values



are "appropriate".  Please remove the last sentence of this DESCRIPTION:





         "...An entry may not exist in the active state unless all



          objects in the entry have an appropriate value."







7)  mplsLpsConfigDomainIndex and mplsLpsMeConfigDomain





Since MIBs often get stripped out of RFCs, the relationship between the mplsLpsConfigDomainIndex and



the mplsLpsMeConfigDomain needs to be included in the MIB Module itself.





Both DESCRIPTION clauses need to be updated to describe the relationship between these objects.   Verbage such as "When the



value of mplsLpsConfigDomainIndex is the same as the value of mplsLpsMeConfigDomain, that means..." and then explain what



this means.





8)  mplsLpsMeConfigDomain DESCRIPTION (editorial)



         "This object holds the value of protection domain index wherein



          this ME included in.





s/included in/is included/





---