Re: [Netconf] I-D Action: draft-ietf-netconf-rfc7895bis-05.txt

[Ladislav Lhotka <[e-mail]>]

On Mon, 2018-03-19 at 17:54 +0000, Martin Bjorklund wrote:
> Juergen Schoenwaelder <[e-mail]> wrote:
> > On Mon, Mar 05, 2018 at 04:50:51PM +0100, Ladislav Lhotka wrote:
> > > > 
> > > > Note, that the deviation leaf-list is a leafref back to the module 
> > > > list.  Hence, for the YANG instance data to be valid, any entries in
> the 
> > > > deviation list must be included in the modules list.
> > > 
> > > Hmm, even this is actually not true - the type should have
> > > 
> > >   require-instance true;
> > > 
> > > right?
> > 
> > Yes, I think this should be there.
> 
> But require-instance defaults to "true", so it is not needed.

Right, my fault, I thought the default is "false".

Lada

> 
> 
> > > If "module" and "deviation" are required to match, the document
> > > should say so.
> > 
> > Note that section 3 says:
> > 
> >    o  deviation list: The name of each YANG module with deviation
> >       statements affecting a given YANG module, in a given datastore
> >       schema, MUST be identified.
> > 
> > I know, this is in the objectives section and not in the YANG
> > definitions, perhaps we need to make this clear there as well.
> > Perhaps just change
> > 
> > OLD
> > 
> >      "List of YANG deviation modules used by this server to modify
> > 
> > NEW
> > 
> >      "List of all YANG deviation modules used by this server to modify
> 
> Ok, this makese sense.
> 
> 
> /martin
> 
> 
> 
> > 
> > /js
> > 
> > -- 
> > Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> > Phone: [phone]         Campus Ring 1 | 28759 Bremen | Germany
> > Fax:   [phone]         <https://www.jacobs-university.de/>
> > 
-- 
Ladislav Lhotka
Head, CZ.NIC Labs
PGP Key ID: 0xB8F92B08A9F76C67