Re: [netconf] Tsvart last call review of draft-ietf-netconf-restconf-notif-13

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Fri, 12 April 2019 19:24 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B291012079D; Fri, 12 Apr 2019 12:24:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=Q2Cz3cvC; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=b1XFeJCH
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0IaVjx_P3PPa; Fri, 12 Apr 2019 12:24:26 -0700 (PDT)
Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 27AB51201B6; Fri, 12 Apr 2019 12:24:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3610; q=dns/txt; s=iport; t=1555097066; x=1556306666; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=i+VBpf1fY8FTxn+MfRaTJxuG6ivPBqJRRZ9gcz0SSfw=; b=Q2Cz3cvC99ayDsa5GCmHgTcaks5lzLc18iFW4ZUAACY4GmtISzyHyg0O q4pLTQ8FLVKX17N/p4uwdealHB+Ip8EsJRejlE5yAPvxvDmXO31eIeUyI 9o4ZRcHHJ6fq6AHU8KMkVe/Ihey2yAdHqf7mTMT0WjwWmThfYJwhf4469 c=;
IronPort-PHdr: =?us-ascii?q?9a23=3AfWin8hR9fCeaXdx3cSt5prEXyNpsv++ubAcI9p?= =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESXBdfA8/wRje3QvuigQmEG7Zub+FE6OJ1XH1?= =?us-ascii?q?5g640NmhA4RsuMCEn1NvnvOjYgFcRHXVlN9HCgOk8TE8H7NBXf?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BJAAC85bBc/4sNJK1lHAEBAQQBAQc?= =?us-ascii?q?EAQGBUQcBAQsBgT0kBScDaFQgBAsohA6DRwOEUopEgjKXP4EugSQDVA4BASU?= =?us-ascii?q?IhEACF4VfIzQJDgEDAQEKAQIBAm0cDIVLBiMRDAEBNwEPAgEIDgwCJgICAjA?= =?us-ascii?q?VEAIEAQ0FgldLAYFpAxwBAgyhbAKKFHGBL4J5AQEFgTUCg00Ygg0DBoELJwG?= =?us-ascii?q?LSBeBQD+BOAwTgkw+gmEBAQIBgXWCczGCJosbggqZBAkCggWGCIhIg0Qaggi?= =?us-ascii?q?GGoxQi2KGKo1qAgQCBAUCDgEBBYFPOIFWcBU7KgGCQYIKgSQBB4JDhRSFP3K?= =?us-ascii?q?BKY9IAQE?=
X-IronPort-AV: E=Sophos;i="5.60,342,1549929600"; d="scan'208";a="259157396"
Received: from alln-core-6.cisco.com ([173.36.13.139]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 12 Apr 2019 19:24:10 +0000
Received: from XCH-RCD-016.cisco.com (xch-rcd-016.cisco.com [173.37.102.26]) by alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id x3CJOA9g001387 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 12 Apr 2019 19:24:10 GMT
Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-RCD-016.cisco.com (173.37.102.26) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 12 Apr 2019 14:24:09 -0500
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 12 Apr 2019 14:24:09 -0500
Received: from NAM04-CO1-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 12 Apr 2019 14:24:09 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i+VBpf1fY8FTxn+MfRaTJxuG6ivPBqJRRZ9gcz0SSfw=; b=b1XFeJCHwHsYONJ4gRYXLBinVl28bVyezz9tinE3hagqMpUgliCL4Q78VYD9RzR4i/ZRsUqN+/jsbkt8IU3d/tXMybRYFrH7Da3iXGyItGjkMz0t04OlzaXPcqRDRoQX4vnGQ8i/VhormrkBD9D0KxmqJgaoQeSE5gBclWLfYjw=
Received: from MN2PR11MB3695.namprd11.prod.outlook.com (20.178.252.156) by MN2PR11MB3997.namprd11.prod.outlook.com (10.255.181.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.19; Fri, 12 Apr 2019 19:24:07 +0000
Received: from MN2PR11MB3695.namprd11.prod.outlook.com ([fe80::8467:9ef7:d982:e972]) by MN2PR11MB3695.namprd11.prod.outlook.com ([fe80::8467:9ef7:d982:e972%3]) with mapi id 15.20.1771.021; Fri, 12 Apr 2019 19:24:07 +0000
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Wesley Eddy <wes@mti-systems.com>, "tsv-art@ietf.org" <tsv-art@ietf.org>
CC: "netconf@ietf.org" <netconf@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-netconf-restconf-notif.all@ietf.org" <draft-ietf-netconf-restconf-notif.all@ietf.org>
Thread-Topic: Tsvart last call review of draft-ietf-netconf-restconf-notif-13
Thread-Index: AQHU6XMl1tCspDTGH06mi47K3kgElqY4tKGA
Date: Fri, 12 Apr 2019 19:24:06 +0000
Message-ID: <5C1FC2C9-6502-4BE1-A874-705A6BBA571B@cisco.com>
References: <155422336508.6258.5897033458248231423@ietfa.amsl.com>
In-Reply-To: <155422336508.6258.5897033458248231423@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.6.190114
authentication-results: spf=none (sender IP is ) smtp.mailfrom=rrahman@cisco.com;
x-originating-ip: [2001:420:2840:1250:2421:2f0a:1dbc:638e]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1f4a6403-6944-4fcb-0343-08d6bf7c6e93
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:MN2PR11MB3997;
x-ms-traffictypediagnostic: MN2PR11MB3997:
x-ms-exchange-purlcount: 2
x-microsoft-antispam-prvs: <MN2PR11MB39976C55E1EEF216EF84D297AB280@MN2PR11MB3997.namprd11.prod.outlook.com>
x-forefront-prvs: 0005B05917
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(366004)(136003)(396003)(189003)(199004)(106356001)(99286004)(229853002)(105586002)(2616005)(2501003)(83716004)(36756003)(7736002)(6506007)(71200400001)(14454004)(102836004)(305945005)(25786009)(81156014)(97736004)(68736007)(76176011)(81166006)(8936002)(71190400001)(82746002)(86362001)(6436002)(6246003)(33656002)(6512007)(11346002)(6486002)(46003)(8676002)(478600001)(2906002)(6306002)(486006)(186003)(256004)(4326008)(316002)(5660300002)(476003)(54906003)(446003)(58126008)(110136005)(6116002)(53936002)(966005); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3997; H:MN2PR11MB3695.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 2ScvSBJ22vbRDEe6LAkSOWgk+kry95L9Xm8svKdde71uwH6v7ursmOzih2zNl17kqwQeGLdmSOuo9Wd5HdBlFEy7xlk2sLfv6Scu0+wbPc/HXW2CwJ69VKH92sVWZx3Lyh86zZ2bVpAYKwessCag282DC2kfh6xdR8ytRJe+l3gNPnVpH0kr99k2OElyprRHni7bxhl+doCftMGHJsBtWf7+7EIUKroWTVTY7fQg114DryX4/dcC9hZkhLntSLsj9JgMSCE4j+vtjMWjVHP/UxJHXs37SoHUsy2omIP/SEb42vUu5EwJw0wmjHIFngRz94LFyF26YYqDqhCeFsr5ge5xuOALPKQ0oD4GsfeWhXMlhztNZFQTtOBw/8LKkL0mH8QInK8b3kdjfRgiGKjDrM5+KB7sr2duB+YUV0gD0mY=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DC81ADC2F44E0943852EF41717C709EF@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f4a6403-6944-4fcb-0343-08d6bf7c6e93
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 19:24:06.9430 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3997
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.26, xch-rcd-016.cisco.com
X-Outbound-Node: alln-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/l1xOd0S2XoLxNJ7iFrTaAvuC5Ig>
Subject: Re: [netconf] Tsvart last call review of draft-ietf-netconf-restconf-notif-13
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Apr 2019 19:24:29 -0000

Hi Wesley,

Thank you for the review, please see inline.


On 2019-04-02, 12:43 PM, "Wesley Eddy via Datatracker" <noreply@ietf.org> wrote:

    Reviewer: Wesley Eddy
    Review result: Ready with Issues
    
    This document has been reviewed as part of the transport area review team's
    ongoing effort to review key IETF documents. These comments were written
    primarily for the transport area directors, but are copied to the document's
    authors and WG to allow them to address any issues raised and also to the IETF
    discussion list for information.
    
    When done at the time of IETF Last Call, the authors should consider this
    review as part of the last-call comments they receive. Please always CC
    tsv-art@ietf.org if you reply to or forward this review.
    
    I reviewed this in conjunction with the set of related WG documents on
    NETCONF/RESTCONF subscriptions and event notifications.   I have comments that
    will be sent on other documents in the set, some of which may influence this
    once, since they are closely related.
    
    Figure 3 shows a DSCP value of 10, but it isn't clear what the number base is
    supposed to be, and this should be specified for this protocol, since many
    examples can be found in other material of DSCP values indicated in binary,
    decimal, or hexadecimal.
The leaf "dscp" is from https://tools.ietf.org/html/draft-ietf-netconf-subscribed-notifications-23#page-45, and inet:dscp is a uint8 range "0..63". The example in Figure 3 uses JSON encoding, we're following rules from https://tools.ietf.org/html/rfc7951#page-11 so this means that 10 is decimal.
    
    In section 4, the first bullet discusses taking a "priority" and copying it
    into a "weighting" field.  Since priority and weight can be different, though
    are closely related, this seems a bit confusing.  I think the intention here
    for HTTP2 effects that are trying to be achieved should be discussed more so
    that it is clear to implementers and users what more specific effects this
    should have.
As mentioned in the 2nd paragraph, that text is specific to http2. So the intention here is to explain how the weighting/dependency nodes (from subscribed-notifications) are used for http2. If I understood your comment properly, you find bullet 1 confusing since it mentions priority and weight in the same vein? Would this be better:
take the "weighting" leaf node in  [I-D.draft-ietf-netconf-subscribed-notifications], and copy it into the HTTP2 stream weight, [RFC7540] section 5.3,...

Regards,
Reshad.