Re: [netmod] Genart last call review of draft-ietf-netmod-factory-default-14
Qin Wu <bill.wu@huawei.com> Fri, 13 March 2020 12:26 UTC
Return-Path: <bill.wu@huawei.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 380383A170A; Fri, 13 Mar 2020 05:26:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OopMpfOR28LU; Fri, 13 Mar 2020 05:26:48 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 271543A1707; Fri, 13 Mar 2020 05:26:48 -0700 (PDT)
Received: from lhreml705-cah.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 97BC8D7989A64194D5FD; Fri, 13 Mar 2020 12:26:43 +0000 (GMT)
Received: from lhreml715-chm.china.huawei.com (10.201.108.66) by lhreml705-cah.china.huawei.com (10.201.108.46) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 13 Mar 2020 12:26:43 +0000
Received: from lhreml715-chm.china.huawei.com (10.201.108.66) by lhreml715-chm.china.huawei.com (10.201.108.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Mar 2020 12:26:43 +0000
Received: from DGGEML404-HUB.china.huawei.com (10.3.17.39) by lhreml715-chm.china.huawei.com (10.201.108.66) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Fri, 13 Mar 2020 12:26:43 +0000
Received: from DGGEML511-MBS.china.huawei.com ([169.254.4.27]) by DGGEML404-HUB.china.huawei.com ([fe80::b177:a243:7a69:5ab8%31]) with mapi id 14.03.0439.000; Fri, 13 Mar 2020 20:26:41 +0800
From: Qin Wu <bill.wu@huawei.com>
To: Stewart Bryant <stewart.bryant@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "netmod@ietf.org" <netmod@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "draft-ietf-netmod-factory-default.all@ietf.org" <draft-ietf-netmod-factory-default.all@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-netmod-factory-default-14
Thread-Index: AdX5MiBOXr9p4glsTfqsi62IZ4V4xg==
Date: Fri, 13 Mar 2020 12:26:40 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABAAD54B417@dggeml511-mbs.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.138.33.123]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/okEDX1AUWq1bz755rxuxUqdGcRU>
Subject: Re: [netmod] Genart last call review of draft-ietf-netmod-factory-default-14
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Mar 2020 12:26:55 -0000
Thanks Stewart for a good review, see reply inline below. -----邮件原件----- 发件人: Stewart Bryant via Datatracker [mailto:noreply@ietf.org] 发送时间: 2020年3月12日 21:12 收件人: gen-art@ietf.org 抄送: netmod@ietf.org; last-call@ietf.org; draft-ietf-netmod-factory-default.all@ietf.org 主题: Genart last call review of draft-ietf-netmod-factory-default-14 Reviewer: Stewart Bryant Review result: Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-netmod-factory-default-14 Reviewer: Stewart Bryant Review Date: 2020-03-12 IETF LC End Date: 2020-03-16 IESG Telechat date: Not scheduled for a telechat Summary: A well written document that is pretty much ready to go. I only have one concern and that is whether the overwrite pattern needs some text so that it does not accidentally become a covert channel. Major issues: None Minor issues: "All security sensitive data (i.e., private keys, passwords, etc.) SHOULD be overwritten with zeros or a pattern before deletion. " "a pattern" is possibly vague, and care needs to be taken that this is not a covert channel. Possibly it needs to say something like "an implementation specific common pattern"? [Qin]: The proposed change works for me, maybe "common" should also be removed. Nits/editorial comments: Nits contains a warning about references, but one concerns text that will removed, and the other is a format error that will be fixed in publication [Qin]:Correct, YANG library reference is unused and should be removed. I saw the SecDir comment on RPC. This is a starred term in the abbreviation list and does not technically need expanding. [Qin]: Right, RPC is an existing term that is defined in RFC7950, which doesn't need to be expanded.
- [netmod] Genart last call review of draft-ietf-ne… Stewart Bryant via Datatracker
- Re: [netmod] Genart last call review of draft-iet… Qin Wu
- Re: [netmod] [Gen-art] Genart last call review of… Alissa Cooper