IETF Logo Mail Archive

Re: [nfsv4] WGLC review of draft-ietf-nfsv4-umask-02

David Noveck <davenoveck@gmail.com> Tue, 20 December 2016 14:42 UTC

Return-Path: <davenoveck@gmail.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 36CB01299AC for <nfsv4@ietfa.amsl.com>; Tue, 20 Dec 2016 06:42:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i8elqnRn4VXg for <nfsv4@ietfa.amsl.com>; Tue, 20 Dec 2016 06:42:29 -0800 (PST)
Received: from mail-oi0-x233.google.com (mail-oi0-x233.google.com [IPv6:2607:f8b0:4003:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C23241299AA for <nfsv4@ietf.org>; Tue, 20 Dec 2016 06:42:08 -0800 (PST)
Received: by mail-oi0-x233.google.com with SMTP id b126so179682266oia.2 for <nfsv4@ietf.org>; Tue, 20 Dec 2016 06:42:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=09uIVc8CZ9UkfmJKbOR2es6ReCbmy3oP9DaZvhwodRc=; b=Jdbrr9MI2UOoIcNABzlWz5B99hMGZwo+koq4PHsjRrwCoTqmPzQKJu6BJ2H5oV9pSg rxVQ6JUTjMr1O4jp0Jl+64qiKbGhY/jCL+IO9NytQc8BJLAZQ53hPlglXVosyiVWSPAS 1qEEEqsdMzu1P4yXrV4mwubfQ6XTRI7vgXr744FSvrTU3QQCrshEgG5TesVmnd6w/IMJ O0LCinHQZyudO3Z6gc0CDQ4mJyDgHh8hkk0EGa8EWgtex+bIb92snaebtZHX47arHICb bwv5Rkc1u8JfRVj3/smgjqwljedXS4Xn1t8EPyxBnVE1BIsfSL1A3/91CrU7QednBsJE 0NkQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=09uIVc8CZ9UkfmJKbOR2es6ReCbmy3oP9DaZvhwodRc=; b=Dlk497HBPogsPW/rFtchO7c+eZhI+W/SJnZOVzuPibKWQD/WRqcV79lBLHm7eksKBe IoDSUS5okZAHo6xnztCs3xFJlRQKYDjUXdwsTbfB9IniR/oikEUdtQgRaaUKVpP6SibY ix2x22gGtYOGosa/9ZvPxJgfYuPHC9eTpovl1ncma2RdwcHEr6TGeG5nZ3IvVbtktGnd yWOkbXoGdGAO5keNOvapEndjuVvcRFvu+eaIYfoi3xth3N0T0ARfU1yjf2ss2XNP23QC /RpxQvykI3xZGS36hV+S6loufwv0q+EvWbjOjTxw6ZMnjkL1KYYeyk1R0SzH6MgmM1Pm 1dPA==
X-Gm-Message-State: AIkVDXIXFjl10F2mvs2HyT/F7mUsqttiUeYd1/6ATNH6SiG79/9o+KEB+HOBK4s/Bz3iufKSzvNRMH6XHWsDIQ==
X-Received: by 10.157.60.203 with SMTP id t11mr1570829otf.235.1482244928167; Tue, 20 Dec 2016 06:42:08 -0800 (PST)
MIME-Version: 1.0
Received: by 10.182.137.202 with HTTP; Tue, 20 Dec 2016 06:42:07 -0800 (PST)
In-Reply-To: <20161208220032.GC26583@fieldses.org>
References: <CADaq8jcDbT=TYPEYXkFHV3pEG465WNyABX=JP=89oOAORZ+bGA@mail.gmail.com> <20161208215253.GA25054@fieldses.org> <20161208220032.GC26583@fieldses.org>
From: David Noveck <davenoveck@gmail.com>
Date: Tue, 20 Dec 2016 09:42:07 -0500
Message-ID: <CADaq8jcHKaZuJ+oQH9VVvYirRu_J-kiTdok9og7qREzs3kb9Nw@mail.gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Content-Type: multipart/alternative; boundary="94eb2c19221669e4980544180a84"
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/uhL96p3lfOZxSOVh9KLPuxDHJqw>
Cc: "J. Bruce Fields" <bfields@redhat.com>, "nfsv4@ietf.org" <nfsv4@ietf.org>
Subject: Re: [nfsv4] WGLC review of draft-ietf-nfsv4-umask-02
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Dec 2016 14:42:31 -0000

> Thanks for the review.  I ignored or reworded a couple suggestions, but
> don't think there's any substantive disagreement.

I agree.  I expect that, once the finalized version is submitted, this
document will
be ready to be pushed forward.

> Also I still need to figure out what if anything to do about the xdr.

I think you need to decide on this.  I believe that part of the shepherding
write-up
requires the shepherd (i.e Spencer) to vouch for the adequacy/correctness
of the XDR.
I suggest that you work directly with him to arrive at something he is
comfortable signing
off on.  There's no need to cc the working group but you can if you want to.

> For what it's worth, current state is at:

>        http://git.linux-nfs.org/?p=bfields/NFSv4-umask.git;a=summary

> so e.g. you can browse changes to source from this review at:

>      http://git.linux-nfs.org/?p=bfields/NFSv4-umask.git;a=commitdiff;h=
0ac2b3d9cbc28b3cfc508dad86c6d89288e98b3b

I only saw one noteworthy issue, which  would probably be caught in the
review process, but it make things easier to deal with this stylistic issue
now.

This issue makes inheritable ACLs useless in some common cases. We
make them useful in these cases by defining a new attribute
which allows the server to ignore the umask in the presence of
inheritable permissions.


Suggest replacing "We make" by "This document makes"

On Thu, Dec 8, 2016 at 5:00 PM, J. Bruce Fields <bfields@fieldses.org>
wrote:

> On Thu, Dec 08, 2016 at 04:52:53PM -0500, bfields wrote:
> > Thanks for the review.  I ignored or reworded a couple suggestions, but
> > don't think there's any substantive disagreement.
> >
> > Also I still need to figure out what if anything to do about the xdr.
>
> For what it's worth, current state is at:
>
>         http://git.linux-nfs.org/?p=bfields/NFSv4-umask.git;a=summary
>
> so e.g. you can browse changes to source from this review at:
>
>         http://git.linux-nfs.org/?p=bfields/NFSv4-umask.git;a=
> commitdiff;h=0ac2b3d9cbc28b3cfc508dad86c6d89288e98b3b
>
> --b.
>

v2.23.0 | Report a Bug | By Email