Re: [OAUTH-WG] AD review of draft-ietf-oauth-revocation-06
Stephen Farrell <stephen.farrell@cs.tcd.ie> Fri, 12 April 2013 20:54 UTC
Return-Path: <stephen.farrell@cs.tcd.ie>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D576721F8EC1 for <oauth@ietfa.amsl.com>; Fri, 12 Apr 2013 13:54:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bIq0ZFj1WJyX for <oauth@ietfa.amsl.com>; Fri, 12 Apr 2013 13:54:06 -0700 (PDT)
Received: from mercury.scss.tcd.ie (mercury.scss.tcd.ie [134.226.56.6]) by ietfa.amsl.com (Postfix) with ESMTP id D1CFA21F8E99 for <oauth@ietf.org>; Fri, 12 Apr 2013 13:54:05 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mercury.scss.tcd.ie (Postfix) with ESMTP id E6FF8BE62 for <oauth@ietf.org>; Fri, 12 Apr 2013 21:53:43 +0100 (IST)
X-Virus-Scanned: Debian amavisd-new at scss.tcd.ie
Received: from mercury.scss.tcd.ie ([127.0.0.1]) by localhost (mercury.scss.tcd.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pwZCjn57MPBw for <oauth@ietf.org>; Fri, 12 Apr 2013 21:53:38 +0100 (IST)
Received: from [10.87.48.8] (unknown [86.46.18.6]) by mercury.scss.tcd.ie (Postfix) with ESMTPSA id CB79ABE61 for <oauth@ietf.org>; Fri, 12 Apr 2013 21:53:37 +0100 (IST)
Message-ID: <51687451.3020307@cs.tcd.ie>
Date: Fri, 12 Apr 2013 21:53:37 +0100
From: Stephen Farrell <stephen.farrell@cs.tcd.ie>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
MIME-Version: 1.0
To: "oauth@ietf.org" <oauth@ietf.org>
References: <51644F9A.9040402@cs.tcd.ie>
In-Reply-To: <51644F9A.9040402@cs.tcd.ie>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [OAUTH-WG] AD review of draft-ietf-oauth-revocation-06
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Apr 2013 20:54:09 -0000
Hi, I'm surprised there've been no responses. I thought there was more interest in this one. Ta, S. On 04/09/2013 06:27 PM, Stephen Farrell wrote: > > Hi, > > I've done my AD review of this draft. I have two quick questions > I'd like to get answered before I start IETF LC. Depending on the > answers maybe we should re-spin or just fire ahead, let's see... > > (1) 2.1: "upon the return of the request" isn't right is it? I > think you mean the response at least. And what about HTTP error > handling? What if I get a 503 error? Is the client supposed > to re-send ever? Don't you need to say? > > (2) 2.2: what's in the response body with a 200 response? If it > doesn't matter please say so. > > I see from the write-up one author hasn't confirmed there are > no IPR issues. I've sent a Marius a mail so hopefully we > can sort that as we go. > > I also have the following nits that can be fixed (if need > be) whenever the draft is next changed: > > - intro: "app" isn't really a great term to use, can you replace > with something from 6479. > > - section 2: the "MAY include a query component" is sort of > dangling there, maybe it'd be better moved elsewhere? > > - section 2: "MUST be obtained from a trustworthy source." might > generate comment from IESG members who don't like using 2119 > terms in ways that don't affect interoperability. (I'm fine with > it fwiw, and have nearly cured 'em of that craze;-) Consider > s/MUST/need to/ here. > > - 2.1: ought there be a registry for token_type_hint values? It > looks like maybe there ought be. > > - 2.1: "A client compliant with [RFC6749] must be prepared" was > that meant to be a 2119 MUST? > > - section 6: maybe s/shall/need to/ in the last para > > Cheers, > S. > > _______________________________________________ > OAuth mailing list > OAuth@ietf.org > https://www.ietf.org/mailman/listinfo/oauth > >
- [OAUTH-WG] AD review of draft-ietf-oauth-revocati… Stephen Farrell
- Re: [OAUTH-WG] AD review of draft-ietf-oauth-revo… Stephen Farrell
- Re: [OAUTH-WG] AD review of draft-ietf-oauth-revo… Justin Richer
- Re: [OAUTH-WG] AD review of draft-ietf-oauth-revo… Stephen Farrell
- Re: [OAUTH-WG] AD review of draft-ietf-oauth-revo… Torsten Lodderstedt
- Re: [OAUTH-WG] AD review of draft-ietf-oauth-revo… Torsten Lodderstedt
- Re: [OAUTH-WG] AD review of draft-ietf-oauth-revo… Stephen Farrell