Re: [OAUTH-WG] Facebook updates to Draft 10

Olivier POITREY <rs@dailymotion.com> Fri, 10 September 2010 14:00 UTC

Return-Path: <rs@dailymotion.com>
X-Original-To: oauth@core3.amsl.com
Delivered-To: oauth@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 831DE3A68BC for <oauth@core3.amsl.com>; Fri, 10 Sep 2010 07:00:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OhwupjA5udhP for <oauth@core3.amsl.com>; Fri, 10 Sep 2010 06:59:59 -0700 (PDT)
Received: from intsvc-02.dailymotion.com (intsvc-02.dailymotion.com [195.8.215.88]) by core3.amsl.com (Postfix) with ESMTP id DF9733A6403 for <oauth@ietf.org>; Fri, 10 Sep 2010 06:59:58 -0700 (PDT)
Received: from EXCHANGE-02.daily.local (unknown [195.8.215.118]) by intsvc-02.dailymotion.com (Postfix) with ESMTP id 4602FA4ADA; Fri, 10 Sep 2010 16:00:25 +0200 (CEST)
Received: from EXCHANGE-02.daily.local ([195.8.215.118]) by exchange-02 ([195.8.215.118]) with mapi; Fri, 10 Sep 2010 15:57:20 +0200
From: Olivier POITREY <rs@dailymotion.com>
To: Paul Tarjan <paul.tarjan@facebook.com>
Date: Fri, 10 Sep 2010 16:00:24 +0200
Thread-Topic: [OAUTH-WG] Facebook updates to Draft 10
Thread-Index: ActQ8BWrD5b4ee/wRgOu98QFUtgg7g==
Message-ID: <F3BF13A1-D3FC-4398-8288-A1DC3387DDD5@dailymotion.com>
References: <116056AD-0AC4-4BD9-BCF4-C4D2A75CF9D6@facebook.com> <2ED35478-18D0-452C-AF4C-C5556809A97A@dailymotion.com> <F36BEEAF-078A-4BD8-8061-50F03BE3F0F7@facebook.com>
In-Reply-To: <F36BEEAF-078A-4BD8-8061-50F03BE3F0F7@facebook.com>
Accept-Language: en-US, fr-FR
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US, fr-FR
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: OAuth WG <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Facebook updates to Draft 10
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Sep 2010 14:00:00 -0000

http://developers.facebook.com/docs/authentication/

Section: "Requesting Extended Permissions"

"[…]To request permissions via OAuth, use the scope argument in your authorization request, and include a _comma_ separated list of all the permissions you want to request.[…]"

The example shows comma as well.


Accepting both is ok for compat, but how can you be backward compatible in responses? Will whitespace be the long term delimiter for the scope field? Github for instance uses commas as well in their current implementation. I've actually never seen a public implementation using whitespaces so far. Wouldn't it be better to change the spec to comply with most current implementations? What motivated this choice in the first place?


On 10 sept. 2010, at 15:19, Paul Tarjan wrote:

> Hi Olivier,
> 
> We should be accepting both (since we are trying to be backwards compatible with Draft 00)
> 
> http://graph.facebook.com/oauth/authorize?client_id=150629244948164&redirect_uri=http://paulisageek.com/facebook/app/&scope=publish_stream%20offline_access%20xmpp_login
> 
> Does one of our docs pages recommend a comma separated string? If so, please send me the URL and I'll update it.
> 
> Paul
> 
> On Sep 10, 2010, at 4:46 AM, Olivier POITREY wrote:
> 
>> Hi Paul,
>> 
>> Your implementation (and most other oAuth 2.0 implementations I've seen so far) are not using whitespace delimiter for the scope field. As I'm currently working on an oAuth 2.0 implementation for Dailymotion, I'm wondering why nobody seems to follow this part of the spec and use comas instead of whitespaces. Note that I would prefer coma over whitespace, whitespace have to be encoded and I find it a bit counter intuitive for this field.
>> 
>> Best,
>> 
>> 
>> On 9 sept. 2010, at 20:43, Paul Tarjan wrote:
>> 
>>> Hi Fellow OAuthers,
>>> 
>>> We just updated our Graph API's OAuth2 implementation to be draft 10 complaint. Yay!
>>> 
>>> Well, I should say we are pretty close to draft 10. Some places we differ:
>>> 
>>> * For now errors are not in the standard format :( This would break backwards compatibility and existing applications, so we are only going to turn it on for opted in applications until the spec is finalized. If anyone wants to use the new formats, send me your Facebook app's ID and I'll opt you in.
>>> * if grant_type is not included, it is assumed to be "authorization_code" since that is what draft-00 did.
>>> * If response_type is not included, it is assumed to be "code" since that is what draft-00 did.
>>> 
>>> When the spec is finalized, we plan on doing a single opt-in migration for all non-backwards compatible changes. New application will be automatically on the final version, and older applications will have a time period to update.
>>> 
>>> Some new things you can do:
>>> 
>>> Here are a few links showing some of the new parameters to help you with discovery:
>>> code_and_token: 
>>> http://graph.facebook.com/oauth/authorize?client_id=150629244948164&redirect_uri=http://paulisageek.com/facebook/app/&response_type=code_and_token
>>> token: 
>>> http://graph.facebook.com/oauth/authorize?client_id=150629244948164&redirect_uri=http://paulisageek.com/facebook/app/&response_type=token
>>> new error format:
>>> http://graph.facebook.com/oauth/access_token?client_id=150629244948164&redirect_uri=http://paulisageek.com/facebook/app/
>>> error redirects:
>>> http://graph.facebook.com/oauth/authorize?client_id=150629244948164&redirect_uri=http://paulisageek.com/facebook/app/&grant_type=junky_junk
>>> 
>>> Feel free to ask questions and let me know if there are any places you don't think we are spec complaint. We plan on keeping up with changes as we all run this last mile to the final version.
>>> 
>>> Thanks!
>>> Paul
>>> 
>>> _______________________________________________
>>> OAuth mailing list
>>> OAuth@ietf.org
>>> https://www.ietf.org/mailman/listinfo/oauth
>> 
>