Re: [Pce] Shepherd Review of draft-ietf-pce-association-group-06
Dhruv Dhody <dhruv.ietf@gmail.com> Thu, 07 March 2019 14:01 UTC
Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0927C127981; Thu, 7 Mar 2019 06:01:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O0Q-a7oPsA68; Thu, 7 Mar 2019 06:01:23 -0800 (PST)
Received: from mail-it1-x12c.google.com (mail-it1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 584E4124184; Thu, 7 Mar 2019 06:01:23 -0800 (PST)
Received: by mail-it1-x12c.google.com with SMTP id d125so8000952ith.1; Thu, 07 Mar 2019 06:01:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3SfUtiD56tMT52/AUQgk9mucAr7vHaAhtjWDTWYPdzk=; b=rktNzw7aeCiD4z+1nKretEKdeV3g9kWPo5weTT8nyei/5fnJtOyHzv1fxNzKd7xb4d h82LyEO33bBuCsrTBEUHTUdeGy8qV2ukbUhl3mlyDJBMyQWoYj6IimaQgNTkJyj+zDk/ Fzn3tXyy24co3whoAiA/o3srgLVi0P4k6wtxX2VcJb89mzV8adejU4cNEgBcmSAzBc3T PSf8hSS6WhJAruEJIAfEFQOwXeci8LNaehj0JB+utgdmpaYa0GHmygKaLLHf1tHhJPBe Rkc7snqrumvTH2takzCR1ceeWQl/hjT71WuOoPPE8XoEBMQ3I1NDZLT1uMbN77Ku/5WJ Xbbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3SfUtiD56tMT52/AUQgk9mucAr7vHaAhtjWDTWYPdzk=; b=SRH5Jh7H5DahXn+BTzAeZd7oS8N3TF4Vj8rHfaS5C875htiAteLyI2qP8cZUFIyy6d BevSjYJKgfo4JWmoqh3IBdziDrZwKRKXYPH/H0gZsOxsLhVgwl7Ojv61ns8W6R+a2AXY ghXTVc9Tv8JAgCb97Lul39F4fI0pIK3b7gCUuXVQpO1k/Yd8lVj9z4WxU5wmC22v4uEm Y6rEGRHFFtskbpOEVaEoicgmcgvCXs/FkLIoDk04xOCiV/VvTVbhGiJeWYHQbBa/X782 Xa784OueVW9VuIbNW7AlXOWEtn2zksqoX3KLWAqhxj59DO3G1ygcs6J/GF+69uzFXct8 sY1Q==
X-Gm-Message-State: APjAAAUbT5hP0SKs3x6U9RDt1IfBqDbojYjos5lNQLSmhGM9XgVCy/JN Vg7JBconBnWR1gzt4Yr0jwO5D8kwH7MHXqTZHic=
X-Google-Smtp-Source: APXvYqzYnrQ0UW+HCyNRpURWHp+PARQEWMK0gGd+IA2/weOdJu+uu4tqFf3LC+EYGhVtR0lkcALKZGWM9tRYg0AZiIo=
X-Received: by 2002:a05:660c:30b:: with SMTP id u11mr5132506itj.67.1551967282381; Thu, 07 Mar 2019 06:01:22 -0800 (PST)
MIME-Version: 1.0
References: <23CE718903A838468A8B325B80962F9B8D98F3A8@BLREML503-MBX.china.huawei.com> <31851_1551964509_5C81195D_31851_180_1_9c86f0ca-264c-1ca2-b610-fa9f468a0d49@orange.com>
In-Reply-To: <31851_1551964509_5C81195D_31851_180_1_9c86f0ca-264c-1ca2-b610-fa9f468a0d49@orange.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Thu, 07 Mar 2019 19:30:46 +0530
Message-ID: <CAB75xn4oorZYB1ydZqX+xXPXDbxd6pQoCnV312Ux+zRAxZzFOQ@mail.gmail.com>
To: Julien Meuric <julien.meuric@orange.com>
Cc: Dhruv Dhody <dhruv.dhody@huawei.com>, "draft-ietf-pce-association-group@ietf.org" <draft-ietf-pce-association-group@ietf.org>, "pce@ietf.org" <pce@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000091c7da0583818aca"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/1WJwKfm6zFGaO8KakeSox7tukh4>
Subject: Re: [Pce] Shepherd Review of draft-ietf-pce-association-group-06
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Mar 2019 14:01:26 -0000
Hi Julien, My bad! I did some digging and we added this based on Adrian's comment [1] back in Feb last year (and my memory failed me). How about - The Assoc-type MAY appear more than once in the OP-CONF-ASSOC-RANGE TLV in the case of a non-contiguous Operator-configured Association Range. The PCEP speaker originating this TLV MUST NOT carry overlapping ranges for an association type. If a PCEP peer receives overlapping ranges for an association type, it MUST consider the Open message malformed and MUST reject the PCEP session with error type 1 and error value 1 (PCEP session establishment failure / Reception of an invalid Open message). Thanks! Dhruv [1] https://mailarchive.ietf.org/arch/msg/pce/QSobS2pul-lIlMLXV4KcBhwgBM0 On Thu, Mar 7, 2019 at 6:45 PM <julien.meuric@orange.com> wrote: > Hi Dhruv, > > Congratulation from the prompt update. I'm fine with the <a, b> notation > for ranges. > > The only open issue is the text you add below: > - Is there a reason to prohibit, for a given Association type, split > operator-configured ranges? I don't think this is what the original > version suggested. > - Assuming we proceed with this new rule, then why so much text about > overlapping ranges? To have this happen, the TLV would already break > that "present only once" rule: why would an implementation care about > checking if ranges overlap if the TLV is already wrong? > > Thanks, > > Julien > > > On 07/03/2019 09:28, Dhruv Dhody wrote: > >> ------ > >> 5.1. Procedure > >> --- > >> - The current text only indirectly tackles the case where a given Assoc- > >> type is advertised multiple times, when forbidding overlapping ranges. A > >> complementary sentence explicitly mentioning non-overlapping ranges > would > >> be welcome. > > [[Dhruv Dhody]] Added - > > > > An Assoc-Type MUST be present only once in the OP-CONF-ASSOC-RANGE > > TLV, if the same Assoc-Type is present more than once, the PCEP > > session MUST be rejected with error type 1 and error value 1 (PCEP > > session establishment failure / Reception of an invalid Open > > message). > > > > > _________________________________________________________________________________________________________________________ > > Ce message et ses pieces jointes peuvent contenir des informations > confidentielles ou privilegiees et ne doivent donc > pas etre diffuses, exploites ou copies sans autorisation. Si vous avez > recu ce message par erreur, veuillez le signaler > a l'expediteur et le detruire ainsi que les pieces jointes. Les messages > electroniques etant susceptibles d'alteration, > Orange decline toute responsabilite si ce message a ete altere, deforme ou > falsifie. Merci. > > This message and its attachments may contain confidential or privileged > information that may be protected by law; > they should not be distributed, used or copied without authorisation. > If you have received this email in error, please notify the sender and > delete this message and its attachments. > As emails may be altered, Orange is not liable for messages that have been > modified, changed or falsified. > Thank you. > >
- [Pce] Shepherd Review of draft-ietf-pce-associati… julien.meuric
- Re: [Pce] Shepherd Review of draft-ietf-pce-assoc… Dhruv Dhody
- Re: [Pce] Shepherd Review of draft-ietf-pce-assoc… julien.meuric
- Re: [Pce] Shepherd Review of draft-ietf-pce-assoc… Dhruv Dhody
- Re: [Pce] Shepherd Review of draft-ietf-pce-assoc… julien.meuric