Re: [Pce] Shepherd Review of draft-ietf-pce-association-group-06

<julien.meuric@orange.com> Thu, 07 March 2019 16:21 UTC

Return-Path: <julien.meuric@orange.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3CE61314AE; Thu, 7 Mar 2019 08:21:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.29
X-Spam-Level:
X-Spam-Status: No, score=-0.29 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FORGED_MUA_MOZILLA=2.309, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GPF0DSpmO6xs; Thu, 7 Mar 2019 08:21:10 -0800 (PST)
Received: from orange.com (mta239.mail.business.static.orange.com [80.12.66.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F77B1314AB; Thu, 7 Mar 2019 08:21:10 -0800 (PST)
Received: from opfedar06.francetelecom.fr (unknown [xx.xx.xx.8]) by opfedar26.francetelecom.fr (ESMTP service) with ESMTP id 44FbTw6CW8zFqWP; Thu, 7 Mar 2019 17:21:08 +0100 (CET)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.23]) by opfedar06.francetelecom.fr (ESMTP service) with ESMTP id 44FbTw5Vvmz3wbD; Thu, 7 Mar 2019 17:21:08 +0100 (CET)
Received: from OPEXCLILM32.corporate.adroot.infra.ftgroup (10.114.31.32) by OPEXCAUBM41.corporate.adroot.infra.ftgroup (10.114.13.23) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Mar 2019 17:21:08 +0100
Received: from [10.193.71.36] (10.168.234.2) by OPEXCLILM32.corporate.adroot.infra.ftgroup (10.114.31.32) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Mar 2019 17:21:08 +0100
To: Dhruv Dhody <dhruv.ietf@gmail.com>
CC: Dhruv Dhody <dhruv.dhody@huawei.com>, "draft-ietf-pce-association-group@ietf.org" <draft-ietf-pce-association-group@ietf.org>, "pce@ietf.org" <pce@ietf.org>
References: <23CE718903A838468A8B325B80962F9B8D98F3A8@BLREML503-MBX.china.huawei.com> <31851_1551964509_5C81195D_31851_180_1_9c86f0ca-264c-1ca2-b610-fa9f468a0d49@orange.com> <CAB75xn4oorZYB1ydZqX+xXPXDbxd6pQoCnV312Ux+zRAxZzFOQ@mail.gmail.com>
From: julien.meuric@orange.com
Organization: Orange
Message-ID: <13422_1551975668_5C8144F4_13422_6_1_03ee1c89-8ee9-2c83-b38e-07c0abcfb916@orange.com>
Date: Thu, 07 Mar 2019 17:19:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <CAB75xn4oorZYB1ydZqX+xXPXDbxd6pQoCnV312Ux+zRAxZzFOQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Originating-IP: [10.168.234.2]
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/x7e2MIq_XWozQRdfEwlRWbBWYyk>
Subject: Re: [Pce] Shepherd Review of draft-ietf-pce-association-group-06
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Mar 2019 16:21:12 -0000

This sentence is clear enough to address my concern.

Thank you!

Julien


On 07/03/2019 15:00, Dhruv Dhody wrote:
> Hi Julien, 
>
> My bad! 
> I did some digging and we added this based on Adrian's comment [1]
> back in Feb last year (and my memory failed me). 
>
> How about - 
>
>    The Assoc-type MAY appear more than once in the OP-CONF-ASSOC-RANGE
>    TLV in the case of a non-contiguous Operator-configured Association
>    Range.  The PCEP speaker originating this TLV MUST NOT carry
>    overlapping ranges for an association type.  If a PCEP peer receives
>    overlapping ranges for an association type, it MUST consider the Open
>    message malformed and MUST reject the PCEP session with error type 1
>    and error value 1 (PCEP session establishment failure / Reception of
>    an invalid Open message).
>
> Thanks! 
> Dhruv 
>
> [1] https://mailarchive.ietf.org/arch/msg/pce/QSobS2pul-lIlMLXV4KcBhwgBM0
>
> On Thu, Mar 7, 2019 at 6:45 PM <julien.meuric@orange.com
> <mailto:julien.meuric@orange.com>> wrote:
>
>     Hi Dhruv,
>
>     Congratulation from the prompt update. I'm fine with the <a, b>
>     notation
>     for ranges.
>
>     The only open issue is the text you add below:
>     - Is there a reason to prohibit, for a given Association type, split
>     operator-configured ranges? I don't think this is what the original
>     version suggested.
>     - Assuming we proceed with this new rule, then why so much text about
>     overlapping ranges? To have this happen, the TLV would already break
>     that "present only once" rule: why would an implementation care about
>     checking if ranges overlap if the TLV is already wrong?
>
>     Thanks,
>
>     Julien
>
>
>     On 07/03/2019 09:28, Dhruv Dhody wrote:
>     >> ------
>     >> 5.1. Procedure
>     >> ---
>     >> - The current text only indirectly tackles the case where a
>     given Assoc-
>     >> type is advertised multiple times, when forbidding overlapping
>     ranges. A
>     >> complementary sentence explicitly mentioning non-overlapping
>     ranges would
>     >> be welcome.
>     > [[Dhruv Dhody]] Added -
>     >
>     >    An Assoc-Type MUST be present only once in the
>     OP-CONF-ASSOC-RANGE
>     >    TLV, if the same Assoc-Type is present more than once, the PCEP
>     >    session MUST be rejected with error type 1 and error value 1
>     (PCEP
>     >    session establishment failure / Reception of an invalid Open
>     >    message).
>     >
>
>     _________________________________________________________________________________________________________________________
>
>     Ce message et ses pieces jointes peuvent contenir des informations
>     confidentielles ou privilegiees et ne doivent donc
>     pas etre diffuses, exploites ou copies sans autorisation. Si vous
>     avez recu ce message par erreur, veuillez le signaler
>     a l'expediteur et le detruire ainsi que les pieces jointes. Les
>     messages electroniques etant susceptibles d'alteration,
>     Orange decline toute responsabilite si ce message a ete altere,
>     deforme ou falsifie. Merci.
>
>     This message and its attachments may contain confidential or
>     privileged information that may be protected by law;
>     they should not be distributed, used or copied without authorisation.
>     If you have received this email in error, please notify the sender
>     and delete this message and its attachments.
>     As emails may be altered, Orange is not liable for messages that
>     have been modified, changed or falsified.
>     Thank you.
>


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.