Re: [Pce] Shepherd Review of draft-ietf-pce-association-group-06

[Dhruv Dhody <[e-mail]>]

Hi Julien, 

Thanks for your detailed review and providing suggested text. 

Here is the working copy - https://raw.githubusercontent.com/dhruvdhody-huawei/ietf/master/draft-ietf-pce-association-group-08.txt
Diff - https://tools.ietf.org/rfcdiff?url1=draft-ietf-pce-association-group-06&url2=https://raw.githubusercontent.com/dhruvdhody-huawei/ietf/master/draft-ietf-pce-association-group-08.txt

> ------
> 4.1.1. Procedure
> ---
> - The last sentence of the paragraph puzzled me a bit. The current wording
> may suggests that "it is RECOMMENDED to support the aforementioned
> OPTIONAL TLV", which is inconsistent 2119 language. My guess is that it
> should say: "In case the use of the ASSOC-Type-List TLV is triggered by a
> mandatory association type, then it is RECOMMENDED that the PCEP
> implementation include..." Is my understanding correct?

[[Dhruv Dhody]] That is correct. Updated.

> ------
> 5.1. Procedure
> ---
> - The current text only indirectly tackles the case where a given Assoc-
> type is advertised multiple times, when forbidding overlapping ranges. A
> complementary sentence explicitly mentioning non-overlapping ranges would
> be welcome.
[[Dhruv Dhody]] Added - 

   An Assoc-Type MUST be present only once in the OP-CONF-ASSOC-RANGE
   TLV, if the same Assoc-Type is present more than once, the PCEP
   session MUST be rejected with error type 1 and error value 1 (PCEP
   session establishment failure / Reception of an invalid Open
   message).


> ------
> Appendix A.
> ---
> - I am not comfortable with reading ranges in round brackets. Have square brackets been considered?
> - I am not sure about the meaning of the sentence "not PCC or PCE as set
> as NMS id", please rephrase.

 [[Dhruv Dhody]] In case the association source is not a PCEP peer (for
   example an NMS system), then the default range of <0x1000, 0xffff> is
   considered.

Use of [] throws idnits, and thus I am using <>. 

Thanks again for your review. 

Regards,
Dhruv