[Pce] Secdir early review of draft-ietf-pce-pcep-extension-native-ip-29
Ned Smith via Datatracker <noreply@ietf.org> Wed, 31 January 2024 19:54 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: pce@ietf.org
Delivered-To: pce@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F5C2C14F6F2; Wed, 31 Jan 2024 11:54:25 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ned Smith via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: draft-ietf-pce-pcep-extension-native-ip.all@ietf.org, pce@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.4.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170673086511.57536.5395552393929333066@ietfa.amsl.com>
Reply-To: Ned Smith <ned.smith@intel.com>
Date: Wed, 31 Jan 2024 11:54:25 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/YEWl02z1Zr8ceVgniLqZ5_SYgC8>
Subject: [Pce] Secdir early review of draft-ietf-pce-pcep-extension-native-ip-29
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2024 19:54:25 -0000
Reviewer: Ned Smith Review result: Has Nits 1) Section 5 header should capitalize "messages" 2) The introduction says, "It is necessary to use the central control mode described in [RFC8283]". This reads like a mandatory constraint on implementers but is listed as an informative reference. If the I-D doesn't actually depend on RFC8283, but the authors are assuming this context, then the wording could be adjusted to describe the author's assumptions rather than describe it in (almost) normative style. Alternatively, it is a normative requirement that shouldn't exist in the introduction and the reference should move to the normative list. 3) Figure 16 - It isn't clear if TBD1 and TBD2 are gaps in the I-D that the WG has yet to complete vs. extension / extensibility properties that a subsequent I-D might define. 4) Section 10 "The communication of PCE and PCC described in this document should also follow the same procedures, treat the three newly defined objects (BPI, EPR, PPA) associated with the same symbolic path name as the attribute of the same path in the LSP-DB (LSP State Database)." The "should" in this sentence reads as though it is normative. Consider making it upper case. The sentence is potentially easily misread as it isn't clear which procedures is meant by "...the same procedures,...".
- [Pce] Secdir early review of draft-ietf-pce-pcep-… Ned Smith via Datatracker
- [Pce] 答复: Secdir early review of draft-ietf-pce-p… Aijun Wang
- Re: [Pce] 答复: Secdir early review of draft-ietf-p… Smith, Ned