Re: [Pce] WGLC for draft-ietf-pce-segment-routing-policy-cp-12

Mike Koldychev <mkoldych@proton.me> Mon, 18 March 2024 02:31 UTC

Return-Path: <mkoldych@proton.me>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 97477C14F693; Sun, 17 Mar 2024 19:31:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=proton.me
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kRbj5bUyzBRA; Sun, 17 Mar 2024 19:31:31 -0700 (PDT)
Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2F4F5C14F697; Sun, 17 Mar 2024 19:31:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=y35kxtcsnrf7padbbti5hhxydu.protonmail; t=1710729088; x=1710988288; bh=EkQQ0iQ5EAA/1AzMxiVcKP6b5IS6wHL2XMXAmIsSFK0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=dbHQX7FQRVfr24jv4XLVNYTrBAUkkR0W3cw0QOdXuKAxIyZuwXN9BC1xeXw+HfM9G jigJINfP3XsvWhQtb73Kcd+Rft0nbtFV85zWvCvfaQO8Ok90Ipsgv+Oi91MZEj+9P5 rKT9ulJndyyNUkUkWikZzloVv97RcgnqADzXwVcKeUp7sW6SVBPQDi3KLYJXV+nwik KZ/cdNkxD8HarMElTY3GL1i/32ADtv7BLsHRJa4sAwU7qxcZoELQk5w+PNOaemgv6b mX7aIuRu1w7LHGKi+ruLdZ7GIHcTZkx9t+cfSLc3FSB7CJPgTVzGh+qjOda+6ftHQ8 J9KkLSlFdkVAg==
Date: Mon, 18 Mar 2024 02:31:15 +0000
To: Boris Khasanov <bhassanov@yandex-team.ru>
From: Mike Koldychev <mkoldych@proton.me>
Cc: Dhruv Dhody <dd@dhruvdhody.com>, "pce@ietf.org" <pce@ietf.org>, pce-chairs <pce-chairs@ietf.org>, "draft-ietf-pce-segment-routing-policy-cp@ietf.org" <draft-ietf-pce-segment-routing-policy-cp@ietf.org>
Message-ID: <CxMPp0KcjUKVVo_Hq7DvhMnkXduChWrcy1HFEvRW2X4HP-1m6veJMx1At3q_AK2SAFvNNOF0yyXKjRmKtw-5wY7eX0Royi5DxOPOFOq1lEY=@proton.me>
In-Reply-To: <230141706003864@mail.yandex-team.ru>
References: <CAP7zK5a82T3itOURWipyO0YaC4XgmkRwxDeyE4edZHmMCmX0Bg@mail.gmail.com> <230141706003864@mail.yandex-team.ru>
Feedback-ID: 98235495:user:proton
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="b1_AAqNUuuZkHceHXDPJGp2TDcaQ1AUnku5hqoT2uJDqY"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/_HsekzkoVUkEDGig_GiuHYci62s>
Subject: Re: [Pce] WGLC for draft-ietf-pce-segment-routing-policy-cp-12
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Mar 2024 02:31:36 -0000

Hi Boris,

Sorry for the late reply...

1.1) Yes, it's basically always going to be set to 1. There isn't expected to be any other values there in the future, this field is basically unused.

1.2) I've removed that sentence in version 15. I think the intent was that the PCC can have multiple loopbacks, but this text just adds confusion and isn't necessary.

1.3) Normally, when the PCE creates a new LSP in a new Association, it can choose the Association ID however it wants. So if the ID is some 16-bit number, then the PCE can choose a random number for example. But in the SR Policy use-case this can lead to a (very rare) race condition when two PCEs both decide to create the same SR Policy at exactly the same time. Each PCE would choose some random number as the Association ID and each PCE sends its random Association ID in its PCInitiate message. Now the PCC would receive two PCInitiate messages asking to create the same SR Policy (same color and endpoint), but these two messages have different Association IDs. To avoid this mess, it's just cleaner to make Association ID == Color + Endpoint, so that the two PCEs don't have to pick a "random number" for the Association ID. They always send a deterministic value. Hopefully that clears it up?

Thanks,
Mike.

On Tuesday, January 23rd, 2024 at 5:17 AM, Boris Khasanov <bhassanov@yandex-team.ru> wrote:

> Hi all,
> Sorry for being late, I fully support the adoption too.
>
> Some small comments for the better understanding:
> 1) Section 4.1 Association parameters
> 1.1) Association ID which should be set to 1, will it never be used and should be kept as '1" ?
>
> 1.2) This sentence sounds confusing, IMO:
> "If the PCC receives a PCInit message with the Association Source set not to the headend IP but to some globally unique IP address that the headend owns, then the PCC SHOULD accept the PCInit message and create the SRPA with the Association Source that was sent in the PCInit message."
>
> Why do we need such dualism here? I mean this other IP-address which should be delivered to PCE in advance etc. Complicates an implementation IMO.
>
> 1.3) Also not exactly clear how these parameters can help to escape "a race condition when multiple PCEP speakers want to create the same SR Policy at the same time." Can you please clarify?
> 2) Can you please add into section 7 (Implementation status) some info/plans about the Invalidation TLV. It is very important mechanism in practice.
>
> Thank you.
>
> SY,
> Boris
>
> 08.01.2024, 13:29, "Dhruv Dhody" <dd@dhruvdhody.com>:
>
>> Hi WG,
>>
>> This email starts a 2-weeks working group last call for draft-ietf-pce-segment-routing-policy-cp-12.
>>
>> https://datatracker.ietf.org/doc/draft-ietf-pce-segment-routing-policy-cp/
>>
>> Please indicate your support or concern for this draft. If you are opposed to the progression of the draft to RFC, please articulate your concern. If you support it, please indicate that you have read the latest version and it is ready for publication in your opinion. As always, review comments and nits are most welcome.
>>
>> The WG LC will end on Monday 22nd January 2024.
>>
>> A general reminder to the WG to be more vocal during the last-call/adoption.
>>
>> Thanks,
>> Dhruv & Julien
>>
>> ,
>>
>> _______________________________________________
>> Pce mailing list
>> Pce@ietf.org
>> https://www.ietf.org/mailman/listinfo/pce