[pim] Éric Vyncke's No Objection on draft-ietf-pim-igmp-mld-snooping-yang-17: (with COMMENT)

Éric Vyncke via Datatracker <noreply@ietf.org> Thu, 09 July 2020 07:05 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: pim@ietf.org
Delivered-To: pim@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E23E83A07F8; Thu, 9 Jul 2020 00:05:47 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: =?utf-8?q?=C3=89ric_Vyncke_via_Datatracker?= <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-pim-igmp-mld-snooping-yang@ietf.org, pim-chairs@ietf.org, pim@ietf.org, Stig Venaas <stig@venaas.com>, aretana.ietf@gmail.com, stig@venaas.com
X-Test-IDTracker: no
X-IETF-IDTracker: 7.7.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: =?utf-8?q?=C3=89ric_Vyncke?= <evyncke@cisco.com>
Message-ID: <159427834725.21252.8658233194269644768@ietfa.amsl.com>
Date: Thu, 09 Jul 2020 00:05:47 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/7MsDF9R_xBHkIWMDYQF8Snu8iGI>
Subject: [pim] =?utf-8?q?=C3=89ric_Vyncke=27s_No_Objection_on_draft-ietf-?= =?utf-8?q?pim-igmp-mld-snooping-yang-17=3A_=28with_COMMENT=29?=
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2020 07:05:55 -0000

Éric Vyncke has entered the following ballot position for
draft-ietf-pim-igmp-mld-snooping-yang-17: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-pim-igmp-mld-snooping-yang/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thank you for the work put into this document. On an editorial note, I found
sometimes the text difficult to read (I am not an English-native speaker) due
to very long sentences: e.g., the first 2 paragraphs of section 2.2.

Please find below a couple of non-blocking COMMENTs (and I would appreciate a
reply to each of my COMMENTs).

I hope that this helps to improve the document,

Regards,

-éric

== COMMENTS ==
I am not a big expert in MLD or WiFi, but, it seems to me that this YANG module
covers only the important use case of switches. But, if not mistaken, some WiFi
access points also do a similar job and translates L2 mcast addresses into a
series of L2 unicast addresses. Was it considered in this model ?

-- Section 1.1 --
English is not my native language, but, I have hard time to parse "mrouter:
multicast router, which means nodes attached to a switch have multicast routing
enabled" is a switch or a router ?

-- Section 2.3 --
No need to reply on this one, but, I really do not like separating the IPv4 and
IPv6 branches of the trees. It looks to me like doubling the operational cost
but not sharing common properties; hence, diminishing the usefulness of this
document. I made the same comment for RFC 8652 and there is really no need to
repeat what I consider as mistakes.

-- Section 4 --
The description parts of the YANG module are quite short so I may have
overlooked some parts of it... so bear with my two COMMENTs below:

1) for a MLD group, why having the mac-address leaf ? AFAIK, the mac-address is
derived from the group IPv6 mcast address. Storing related information twice in
a model looks bad to me (I am a big fan of the SQL normal forms...)

2) some switches does not snoop MLD for link-local groups (sollicited node
mcast for example). Is this feature listed in the list of features ?