Re: [pim] Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG Data Model for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard

tom petch <ietfid@btconnect.com> Wed, 22 January 2020 16:20 UTC

Return-Path: <ietfid@btconnect.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 932F9120846; Wed, 22 Jan 2020 08:20:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JPvmd_jS_Ibw; Wed, 22 Jan 2020 08:20:47 -0800 (PST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80102.outbound.protection.outlook.com [40.107.8.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A354012083E; Wed, 22 Jan 2020 08:20:46 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zs3AES+nDHb4mZnGjNkd4b8sp80Rr2E4YKgi7DRsH7+MHpfb7sK7qfwK/n6Z2KbbAV9t0FQzmTYFq+rpzS3HqV1OZWLRbr+YFcxyxJEZ24lJbA+I6XSVWTe4QFFgC6BQg81HAj7Yiug2tdktBo+RSrkriYwthvKts+tuHZuv5ZbPeROvOEPmNw9CgoaGhxxQncJN9z2RDLWfQp6rHkc7iUonEuvCbWXNBDuF5LBaz+onofDLrCll/mPASVRHF9xy4atxle/Tem7ODs9gIcysDX7lekKT0Ld7BAbh4C3xC4DeyfkSwSM7PIllJKD5ADi/IwxNLGWma5tFzdsBR967ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZOVojiNzORVHi5O67G/dJGFQBZTrYVEg/9FUIqevirE=; b=VvHhpCfLfXUTT6dDhd3hBiiOYvsaEDvDOOyTZAhSmsEncnNh3jwxkkXaNtuN6bup2y4UpZ/b0jE2YIDrPSNqM+ZYC5IJObiNznWcqWTDvKsps1YRsccvoaaxZuzPmozJz/1+j9mt6taThifhiqxf4sIFgpIn4yqPCRokoDZpeMnlN6Ne5VCgZBhSQm6izZAzIlNDoRJRZQpT7AHx5lpBa8eyl0XDRxz09/fEaCzScOrxGcw7U71ytc+yOLxbLyasg5nzVPuDMor9JntLRGY/CJMi4KD0EVEfsmOtjFmfIqWn4vpwNKvl/+9T2RD5f/em1/SS0eJDmpwMj82UYATBlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZOVojiNzORVHi5O67G/dJGFQBZTrYVEg/9FUIqevirE=; b=S1U2etDfusshZaaam2cIZwjqsOg9JKFdJas2fmcyc2ZOAaonCYc1XRoG8uFPkGUJpNLAbNBrThNLKgOmjpvj8yHxJv2yZ6FfzuK88Zo9wyR9Pc9iqOuVwUGgz6uS+rkXnmXCn6pLuuSx+korH8BLt7deBGd4Ckqpg6v2PQ4mX3w=
Received: from DB7PR07MB5466.eurprd07.prod.outlook.com (20.178.46.207) by DB7PR07MB5864.eurprd07.prod.outlook.com (20.177.192.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.15; Wed, 22 Jan 2020 16:20:41 +0000
Received: from DB7PR07MB5466.eurprd07.prod.outlook.com ([fe80::189:a440:c88b:bf0]) by DB7PR07MB5466.eurprd07.prod.outlook.com ([fe80::189:a440:c88b:bf0%7]) with mapi id 15.20.2665.017; Wed, 22 Jan 2020 16:20:41 +0000
From: tom petch <ietfid@btconnect.com>
To: IETF-Announce <ietf-announce@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
CC: "draft-ietf-pim-msdp-yang@ietf.org" <draft-ietf-pim-msdp-yang@ietf.org>, "pim-chairs@ietf.org" <pim-chairs@ietf.org>, "pim@ietf.org" <pim@ietf.org>
Thread-Topic: Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG Data Model for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard
Thread-Index: AQHVy+KJkjxS/zh1V023P5eJ+7HcY6f24sEO
Date: Wed, 22 Jan 2020 16:20:41 +0000
Message-ID: <DB7PR07MB5466A46CA66CBBAB96872F16CE0C0@DB7PR07MB5466.eurprd07.prod.outlook.com>
References: <157912016355.29394.13259478860940160505.idtracker@ietfa.amsl.com>
In-Reply-To: <157912016355.29394.13259478860940160505.idtracker@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfid@btconnect.com;
x-originating-ip: [86.139.211.103]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6cbcfc16-41ab-4cd2-e135-08d79f570655
x-ms-traffictypediagnostic: DB7PR07MB5864:
x-microsoft-antispam-prvs: <DB7PR07MB5864E587D09E8F8C7C37395ECE0C0@DB7PR07MB5864.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 029097202E
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(396003)(366004)(39860400002)(376002)(346002)(189003)(199004)(2906002)(9686003)(71200400001)(4326008)(7696005)(55016002)(6506007)(33656002)(52536014)(478600001)(91956017)(76116006)(66446008)(53546011)(54906003)(316002)(64756008)(66476007)(66946007)(8676002)(81166006)(86362001)(8936002)(966005)(110136005)(5660300002)(66556008)(450100002)(186003)(81156014)(26005); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR07MB5864; H:DB7PR07MB5466.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: rqxxbrRKIdCopRTx/txmbg/uL9cMjDWM+wD35klVvGw2Mxm91mSOSxfBVczO8DxzG0zVECxTDPHxw5JT9GZPhBZlZ9taXDHkwiDQva7JWX7J0uy7QIAXRleBm72AC5E7Zc5Ua3pUOYGPHfzyMVBVl69JRmdW0BHo90ayu7/7chMLn6tUOM9rwPgjZzLdsMuid55owa59dvfuBKXvHHQ1UDpAhcBAWmpe4iBBnj3FYsqfIM2PgBZeOKp3af6dsqD440g2SxOlZH+OdsIjmucfWpNfzlrAuVKvwh6FZkTgv+NYDsA3pu5UgENtkBwNd1rdebRcWHYayoI8Y0FpieIOmB6iAHrjn5Y1zT5JF8cNHoI0lH2/EaTZ3qSFap5cNUmG5kuDiI0aAZEeslEv4Xq1rw3B31M7C01cvSgQaPWu+Fiq0esi38/7n5Is3B5IQQF+Sj0VAA+AoNcRCGwpFDnF+nDkJbJ3Mw2jhD62qwzmq58=
x-ms-exchange-antispam-messagedata: KwSa+y2iqLAebAwPZj+RfjK96BQO8gvu9qpWUBbjeLDFqoIkF008oJ5epWPaMtUSKEZlnzwVQcONSHd1/0NRvHEb77rc8iRNhwPKnH/wMulDKdo3l8jpbx0oVyj1hwvVpa3JaDvVOHgkxKLVFMI2fQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cbcfc16-41ab-4cd2-e135-08d79f570655
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2020 16:20:41.0888 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AoJKBD3kI7C2foM0vPs4OW+35ltyDzP1wKA6hrWu64lfM3qmQAmQ487lXk369DoIgwS4i2R2CQy22pbIJs9YHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB5864
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/NLD_dSvnAi055TpSCXg3p9_HS-Y>
Subject: Re: [pim] Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG Data Model for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2020 16:20:50 -0000

RFC8349 says that a new identity MUST be defined for a new control plane protocol - I see no such definition here

RFC8349 says that augments should be to control-plane-protocols/control-plane-protocol as is seen in the OSPF and the other LSR YANG modules; here I see an augment to control-plane-protocols which seems wrong to me

many features but no idea where to look them up - I think every YANG feature needs a YANG reference to an I-D/RFC

I find a list of features and references in the body of an I-D valuable

YANG modules must be plain text; [3618] in the module description does not look like plain text. Other references e.g. RFC8177 look ok although some have a space in them and some do not

leaf tcp-connection-source says that ipv4 must be enabled but the when statement does not test for enabled, just for configured

rpc clear peer clears everything if there is no address - this is fail danger, a specific value for clear all would IMHO be better engineering

XXXX is likely to mean this I-D/RFC but I always like to see a specific direction to the RFC Editor to that effect, just the once, somewhere near the front.

In the same vein, a direction to replace the dates with date of publication  would not go amiss

Tom Petch
________________________________________
From: IETF-Announce <ietf-announce-bounces@ietf.org> on behalf of The IESG <iesg-secretary@ietf.org>
Sent: 15 January 2020 20:29
To: IETF-Announce
Cc: draft-ietf-pim-msdp-yang@ietf.org; pim-chairs@ietf.org; pim@ietf.org
Subject: Last Call: <draft-ietf-pim-msdp-yang-08.txt> (A YANG Data Model for Multicast Source Discovery Protocol (MSDP)) to Proposed Standard


The IESG has received a request from the Protocols for IP Multicast WG (pim)
to consider the following document: - 'A YANG Data Model for Multicast Source
Discovery Protocol (MSDP)'
  <draft-ietf-pim-msdp-yang-08.txt> as Proposed Standard

The IESG plans to make a decision in the next few weeks, and solicits final
comments on this action. Please send substantive comments to the
last-call@ietf.org mailing lists by 2020-01-30. Exceptionally, comments may
be sent to iesg@ietf.org instead. In either case, please retain the beginning
of the Subject line to allow automated sorting.

Abstract


   This document defines a YANG data model for the configuration and
   management of Multicast Source Discovery Protocol (MSDP) Protocol.




The file can be obtained via
https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/

IESG discussion can be tracked via
https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/ballot/


No IPR declarations have been submitted directly on this I-D.




_______________________________________________
IETF-Announce mailing list
IETF-Announce@ietf.org
https://www.ietf.org/mailman/listinfo/ietf-announce