IETF Logo Mail Archive

Re: [pim] draft-ietf-pim-yang-02 WGLC

Stig Venaas <stig@venaas.com> Tue, 04 October 2016 21:06 UTC

Return-Path: <stig@venaas.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 655661294E5 for <pim@ietfa.amsl.com>; Tue, 4 Oct 2016 14:06:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dy0aclXxNUpW for <pim@ietfa.amsl.com>; Tue, 4 Oct 2016 14:06:02 -0700 (PDT)
Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com [IPv6:2a00:1450:4010:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1E91E1294C2 for <pim@ietf.org>; Tue, 4 Oct 2016 14:06:02 -0700 (PDT)
Received: by mail-lf0-x22f.google.com with SMTP id l131so195479942lfl.2 for <pim@ietf.org>; Tue, 04 Oct 2016 14:06:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qJTackSKpNn99JA9TzdG8u7sRFLjASRJyVGSsQAXXj4=; b=skMA9vjoTFmx28NOa0GHaCQ6QefypHLOWH3fT0eYK73/2UAADRmh3ZfCy1xrPtYFfy 7p6dbUicuUpJ2/99n6vTS8RD7rpXgDYdJ73zVErmkMpd9Y+WAarL3Z4BElnWIEc4MEG2 bdzbP6Q4XoWZp7XId2EmdjmhVaXf95R2tqg4+LKqlSJp1zuDskyK4/v+0CEG9Cqq7ien 8WZi819JCZWA+5bIgEsDpN1MT2AWC/w6QT38+wBRDYZSHT4H93jLN4aS6l3fxP/CfQhz yKeDR6vo43BnU/GSrLo6qhnipSlIWfIHNEwVfKQdVrQJGNcaQ/RPubVS2GA1DN5eTkBU ce+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qJTackSKpNn99JA9TzdG8u7sRFLjASRJyVGSsQAXXj4=; b=fRcZoV5xMIKRNn10E4JAMkaVVxw3RGRLjy/6idZU+O6odnHqBfa968DbJ5G7PU2phe XHLBTfUKdds3z56ZHs1R/8gQ+gZFHWrSsNS7ndaCweUBTmlhyCfXBxq7BsHhI+geIjXm AmfwOR1kvBN5TKH2Oc7X+Sbj8Junx81lti3TAApgjrLLzAnrSkXVFllZEwxkanayRbDM g2rAm91Ez/SBQhkRsiPOWRtJWMSYy1xeq03orrxbycNyv/aIbQ2o/fIVmLaTyChZlzG/ g4NiRuiYYvK3rtlGcb7qSUbpJ61kq6cTeF+WpCMez8LXOZ3FPtnLMDtkZXENH+D0wxka 7VeA==
X-Gm-Message-State: AA6/9RngRmwezygnmUQFXjjnCY51dg//K6FqUhyxPLecOs0obVP4/GIbUWRcEVSGNd+Bw6ubM7xmmKp7It+1vQ==
X-Received: by 10.46.71.147 with SMTP id u141mr2388757lja.15.1475615160216; Tue, 04 Oct 2016 14:06:00 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.25.28.15 with HTTP; Tue, 4 Oct 2016 14:05:59 -0700 (PDT)
In-Reply-To: <AM5PR0601MB264132104E69F812CD2F191BB1C10@AM5PR0601MB2641.eurprd06.prod.outlook.com>
References: <8CCB28152EA2E14A96BBEDC15823481A09FBC8FB@dfweml501-mbx> <CAHANBt+GKCUhhZH1NCERq6R5+KbkppUJ6oBK2OAKmGEB2osq-A@mail.gmail.com> <CAHANBt+k3AZoaLPgX1QmJ0eg-rZ6oMkAgepX6o8yL4inXXfj2g@mail.gmail.com> <02c701d201fc$6b2b4570$4181d050$@gmail.com> <8CCB28152EA2E14A96BBEDC15823481A09FDDE32@dfweml501-mbx> <007401d20940$61edff70$25c9fe50$@gmail.com> <CAHANBtKshRW3KU34gjSNoOjswhy9TVm4KXxRPFRCo=HZ1wGCrQ@mail.gmail.com> <CAHANBtLL8ancAkoLsjsxSFiG0GA91jZXw7xDPOdbXdwmnkVPEw@mail.gmail.com> <AM5PR0601MB264132104E69F812CD2F191BB1C10@AM5PR0601MB2641.eurprd06.prod.outlook.com>
From: Stig Venaas <stig@venaas.com>
Date: Tue, 04 Oct 2016 14:05:59 -0700
Message-ID: <CAHANBtL25gsVfVC5T3oFVdA_3pabd6iJAySWK-oUrz1ux7ka=A@mail.gmail.com>
To: Xufeng Liu <xliu@kuatrotech.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/YvDxU-nW2KqSVDR6Kmqi-ZuGpbA>
Cc: "pim@ietf.org" <pim@ietf.org>
Subject: Re: [pim] draft-ietf-pim-yang-02 WGLC
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2016 21:06:04 -0000

Hi

On Fri, Sep 30, 2016 at 4:29 PM, Xufeng Liu <xliu@kuatrotech.com> wrote:
> Hi Stig and All,
>
> Thanks for the comments. I have updated the models and drafts based on these comments. The updated draft and model files are at: https://github.com/mcallisterjp/pim-yang. Any feedbacks will be appreciated.
>
> The update items include the responses to Stig's previous emails, and the comments below.

Great. I have one comment inline below though.

> Thanks,
>
> - Xufeng
>
>> -----Original Message-----
>> From: Stig Venaas [mailto:stig@venaas.com]
>> Sent: Friday, September 16, 2016 5:27 PM
>> To: Xufeng Liu <xufeng.liu.ietf@gmail.com>
>> Cc: Michael McBride <Michael.McBride@huawei.com>; pim@ietf.org
>> Subject: Re: [pim] draft-ietf-pim-yang-02 WGLC
>>
>> Hi
>>
>> I now took some time to review the draft more carefully. Here are comments in
>> addition to what I posted earlier for the WGLC.
>>
>> First some potential issues with the models.
>>
>> I see for hello-interval, jp-interval etc. the data type is timer-value which can
>> also be infinity and no-expiry. Isn't this type to be used for something counting
>> down? These intervals would always be some number of seconds and won't
>> change unless the configuration changes.
> [Xufeng] The "xxx-interval" leaves are the number of seconds that won't change unless the configuration changes.

Right, I understand they are fixed values. That is why I am wondering
whether timer-value is the correct type. Isn't timer-value used for
something that is counting down, and not for fixed values?

Stig

v2.46.0 | Report a Bug | By Email | System Status