Re: [quicwg/base-drafts] Consider making h3 frame types varint (#2253)

Kazuho Oku <notifications@github.com> Mon, 24 December 2018 08:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 559BF130ED8 for <quic-issues@ietfa.amsl.com>; Mon, 24 Dec 2018 00:18:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r29UC1JNY4qh for <quic-issues@ietfa.amsl.com>; Mon, 24 Dec 2018 00:18:42 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDB36130ED7 for <quic-issues@ietf.org>; Mon, 24 Dec 2018 00:18:41 -0800 (PST)
Date: Mon, 24 Dec 2018 00:18:40 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545639520; bh=5ebcjlJfPri2E/R5mW9ZCYvPu6wDYzHruNY5RuUrstE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ztBzBh//L3tA6HE882xeCb2+0ZazwLKZQKx1s5zIYqI2cXhD/7DMHfqBaatTQRN4/ jmh0VxfMU9dM6QVkFX7eOBB7QQHFtwr1wVUvDssmjZbcuwXaYRAATL5scRr7jzMvMd 7BtN/qYE54j6OtSqJfv1TF1qqrwKrUIoQTjs3X8I=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf7770ccb9c2421e40a4677fa8db54b8a61571c0c92cf000000011838586092a169ce17792cde@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2253/449701397@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2253@github.com>
References: <quicwg/base-drafts/issues/2253@github.com>
Subject: Re: [quicwg/base-drafts] Consider making h3 frame types varint (#2253)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c209660a1fee_239e3f8f68ed45b85236f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/072e4IYK2r7N_GettPSp6EvjRF4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Dec 2018 08:18:43 -0000

As stated in 
https://github.com/quicwg/base-drafts/pull/2235#issuecomment-449610469, I do not think that we should make this change.

Our experience from HTTP/2 tells us that it's unlikely that we would run out of the 8-bit number space, and therefore requiring every stack to decode type using varint seems like an unnecessary complexity.

Note that the endpoints would be required to decode the varint even if we decide to enforce minimum-sized encoding. This is because H3 allows use of frame IDs without negotiation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2253#issuecomment-449701397