Re: [quicwg/base-drafts] Prioritization edits (#2322)

Mike Bishop <notifications@github.com> Wed, 09 January 2019 18:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 161F1130FA3 for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 10:11:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zu3qyJOc5wst for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 10:11:13 -0800 (PST)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C3085130FD6 for <quic-issues@ietf.org>; Wed, 9 Jan 2019 10:11:13 -0800 (PST)
Date: Wed, 09 Jan 2019 10:11:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547057473; bh=txOX55Vy5tp3wKxQauTWBrDGxw9XHx8X3RBzTu997F0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zve/Hi/uJwVcLVK6xhYL+KhStX1WwnVBuEkn79TWuVqhVMeUX6U3i/oeYV5v5cItB O8cmkD1WL/72fyoIXXIEVS6oa3Drim4O2KIdHuwWBDtohdrIHiJXbWOo5aVEdN3cuV DcD0x+tgQNAN/9knVbzcZIULBpHsJ6gs+9adh9DE=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1e10473161a86f4846372f89d772118b5246d13392cf00000001184dfb4092a169ce17afe293@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2322/review/190851773@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2322@github.com>
References: <quicwg/base-drafts/pull/2322@github.com>
Subject: Re: [quicwg/base-drafts] Prioritization edits (#2322)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c36394087b56_61c43f8fe92d45c017380ae"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2o3KclvX3Io7fyhAMkldEXUXANc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 18:11:15 -0000

MikeBishop commented on this pull request.

I think the rearrangement is good, but the most awkward paragraph is only moved, not changed.  If you want to clean up this section, maybe try to untangle the paragraph that's now at 1075-1080?

>  
 Due to reordering between streams, an element can also be prioritized which is
 not yet in the tree. Such elements are added to the tree with the requested
 priority.
 
+

Extra blank line here.

>  
 Due to reordering between streams, an element can also be prioritized which is
 not yet in the tree. Such elements are added to the tree with the requested
 priority.
 
+
+In all cases, elements are assigned an initial weight of 16 unless a PRIORITY
+frame begins the stream.

That's only possible for request streams.

>  
 Due to reordering between streams, an element can also be prioritized which is
 not yet in the tree. Such elements are added to the tree with the requested
 priority.
 
+
+In all cases, elements are assigned an initial weight of 16 unless a PRIORITY
+frame begins the stream.
+
+When a client request is first sent, its parent and weight are determined by the
+PRIORITY frame (see {{frame-priority}}) which begins the stream, if present.
+Otherwise, the element is dependent on the root of the priority tree. A request 
+stream dependent upon another request stream expresses the preference that the
+latter stream (the "parent" request) be allocated resources before the former
+stream (the "dependent" request).

This paragraph feels like the thing that needs improvement in this section.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2322#pullrequestreview-190851773