IETF Logo Mail Archive

Re: [quicwg/base-drafts] Prioritization edits (#2322)

Mike Bishop <notifications@github.com> Fri, 11 January 2019 17:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8866124BF6 for <quic-issues@ietfa.amsl.com>; Fri, 11 Jan 2019 09:09:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vs89BYFJ5ke8 for <quic-issues@ietfa.amsl.com>; Fri, 11 Jan 2019 09:09:07 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 09BFC1228B7 for <quic-issues@ietf.org>; Fri, 11 Jan 2019 09:09:07 -0800 (PST)
Date: Fri, 11 Jan 2019 09:09:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547226546; bh=gzvP0N20XeCT+4gfG5HKGYEr+FLSm+D5y0Wbdli6CeM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=L4SijwV/9OOy4Tus87oVWbq8hWzXEmIMyS1Yq1G49iio7BiFO1G+ckMxjOAyY/9MC Qm6IJV8++hNg5qio0GYQ7/kTL8DIw289uG1EGCOhrvxEfLSpkpDEfmLbGNXx683AC5 0ZuirAFYbM6KGDrgVEgM6qDVxamKDdUSYSyqPxzw=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab611e20b2029185e49edd92b05ec00b453750abe492cf0000000118508fb292a169ce17afe293@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2322/review/191756121@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2322@github.com>
References: <quicwg/base-drafts/pull/2322@github.com>
Subject: Re: [quicwg/base-drafts] Prioritization edits (#2322)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c38cdb21e20a_71d23fdf24cd45b81219c1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/C3EutBV7I8Q7lp8WEoDIfp-feAE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 17:09:09 -0000

MikeBishop approved this pull request.

Yes, I like this formulation better.

>  
 Due to reordering between streams, an element can also be prioritized which is
 not yet in the tree. Such elements are added to the tree with the requested
 priority.
 
+When a prioritized element is first created it has a default inital weight
+of 16 and a default dependency. Requests and placeholders are dependent on the
+root of the priority tree, pushes are dependent on the client request on which

```suggestion
root of the priority tree; pushes are dependent on the client request on which
```
Comma splice

>  
 Due to reordering between streams, an element can also be prioritized which is
 not yet in the tree. Such elements are added to the tree with the requested
 priority.
 
+

The extra line was removed in your most recent commit, so don't accept the suggestion to remove another one.  ;-)

>  
 Due to reordering between streams, an element can also be prioritized which is
 not yet in the tree. Such elements are added to the tree with the requested
 priority.
 
+When a prioritized element is first created it has a default inital weight
+of 16 and a default dependency. Requests and placeholders are dependent on the
+root of the priority tree, pushes are dependent on the client request on which
+the PUSH_PROMISE frame was sent.
+
+Requests may override the default intial values by including a PRIORTIY frame
+(see {{frame-priority}}) at the beginning of the stream. Pushes and placeholders
+may be later updated by sending a PRIORITY frame on the control stream.

```suggestion
can be updated by sending a PRIORITY frame on the control stream.
```

>  
 Due to reordering between streams, an element can also be prioritized which is
 not yet in the tree. Such elements are added to the tree with the requested
 priority.
 
+When a prioritized element is first created it has a default inital weight
+of 16 and a default dependency. Requests and placeholders are dependent on the
+root of the priority tree, pushes are dependent on the client request on which
+the PUSH_PROMISE frame was sent.
+
+Requests may override the default intial values by including a PRIORTIY frame
+(see {{frame-priority}}) at the beginning of the stream. Pushes and placeholders

```suggestion
(see {{frame-priority}}) at the beginning of the stream. These priorities
```
It's not just pushes and placeholders -- this statement is true for any of them.

>  
 Due to reordering between streams, an element can also be prioritized which is
 not yet in the tree. Such elements are added to the tree with the requested
 priority.
 
+When a prioritized element is first created it has a default inital weight

```suggestion
When a prioritized element is first created, it has a default initial weight
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2322#pullrequestreview-191756121

v2.23.0 | Report a Bug | By Email