Re: [quicwg/base-drafts] Clarify path validation and connection migration (#4102)

Mike Bishop <notifications@github.com> Fri, 18 September 2020 17:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 193EE3A1211 for <quic-issues@ietfa.amsl.com>; Fri, 18 Sep 2020 10:27:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.177
X-Spam-Level:
X-Spam-Status: No, score=-3.177 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.695, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iVx2c_p_9Ypa for <quic-issues@ietfa.amsl.com>; Fri, 18 Sep 2020 10:27:40 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D417D3A1210 for <quic-issues@ietf.org>; Fri, 18 Sep 2020 10:27:40 -0700 (PDT)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id E48E152042A for <quic-issues@ietf.org>; Fri, 18 Sep 2020 10:27:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1600450059; bh=dJO1KZMa6DNhWv6R6ZWvkj0Hn+L4aTphl01EHHfxG8A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DbP5nMMvfT7YG+ZbQscucEtMOMH/gZ3ywBR4GyH5XaSZYGpG2/viZGXEaywAAiAsK v6IVMTV6ODOmiINSdKYjAWemPjKSfdURCd8ud/ij7LvJKE7YR3zWEN6oqHfjNCntg5 tSrCpQ6MbdW58BK0Bz2bfh8EK+oKATwu8TpgK3Bg=
Date: Fri, 18 Sep 2020 10:27:39 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3B2B2YWGILVRA2XCF5ODHQXEVBNHHCTXOHHI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4102/review/491652495@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4102@github.com>
References: <quicwg/base-drafts/pull/4102@github.com>
Subject: Re: [quicwg/base-drafts] Clarify path validation and connection migration (#4102)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f64ee0bd4cf4_9fa19f0362311"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/4kdhCiAkmyagEaEGh2HRud34yVs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Sep 2020 17:27:42 -0000

@MikeBishop approved this pull request.

Looks like an overall improvement.  We do seem to be losing some text, though I'm not sure if it's critical.

> -An endpoint uses a new connection ID for probes sent from a new local address;
-see {{migration-linkability}} for further discussion. An endpoint that uses
-a new local address needs to ensure that at least one new connection ID is
-available at the peer. That can be achieved by including a NEW_CONNECTION_ID
-frame in the probe.

I initially thought this text was essential to retain, but in fact, it stems from the assumption that the peer is required to reply on the new path (and therefore with a fresh CID).  That's not a bad thing for the peer to do and therefore including the NCID frame in a probe is also worth recommending, but it's not as critical as it used to be.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4102#pullrequestreview-491652495