IETF Logo Mail Archive

Re: [quicwg/base-drafts] Allow alternate restarts after idle (#2187)

ianswett <notifications@github.com> Fri, 14 December 2018 23:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0D84131380 for <quic-issues@ietfa.amsl.com>; Fri, 14 Dec 2018 15:48:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id awtp32EbLbeJ for <quic-issues@ietfa.amsl.com>; Fri, 14 Dec 2018 15:48:32 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E98C7130EED for <quic-issues@ietf.org>; Fri, 14 Dec 2018 15:48:30 -0800 (PST)
Date: Fri, 14 Dec 2018 15:48:29 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544831309; bh=Hy15r37Sm+2UYybxkkgZRvDvwPSacKMkwdVINHn9XfA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cORF1f6Kxv83dqXEAm0QuLu5st8qchhqILPB0GM+ucr/9dqcyXmx0UiVGqWKImo86 gqJJjvazekgpT6EFrTGkxHOAdpLuGl7mT/7VYyAANZjnAAvAXlJW/AG6HvlUGewxfI 629pr8rbhPAxNvRUNLolb2QLB2ROtYcqEfgya4Ks=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd2878b8bb6e4316e0e99d087a4ce7649deff8cd692cf00000001182c034d92a169ce1752fa68@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2187/review/185324195@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2187@github.com>
References: <quicwg/base-drafts/pull/2187@github.com>
Subject: Re: [quicwg/base-drafts] Allow alternate restarts after idle (#2187)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c14414dc5747_22253fef5e4d45bc5955ae"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/69FGsyc_tfgYOq1_gax7GYVXo_U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 23:48:35 -0000

ianswett approved this pull request.

One small suggestion, but LGTM

> @@ -1030,14 +1030,17 @@ application limited or after a retransmission timeout. In order to limit
 the size of bursts sent into the network, the behavior when restarting from
 idle depends upon whether pacing is used.
 
-If the sender uses pacing, the connection should limit the initial burst of
-packets to no more than the initial congestion window and subsequent packets
-SHOULD be paced. The congestion window does not change while the connection
-is idle.
+If the sender uses pacing, the congestion window MUST not increase and does not

Possibly the "MUST not increase CWND" part should move a paragraph up, since it's really not pacing specific?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2187#pullrequestreview-185324195

v2.23.0 | Report a Bug | By Email