Re: [quicwg/base-drafts] Allow alternate restarts after idle (#2187)

ianswett <notifications@github.com> Tue, 18 December 2018 02:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2B9E130F8B for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 18:28:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nq5XVqZu4PrN for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 18:28:29 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A3D212F1A5 for <quic-issues@ietf.org>; Mon, 17 Dec 2018 18:28:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=nAq3DvLGZGxsRhyGzumHT417Zvs=; b=K8oK9ipwrq6lM7Pw wh3/K/vTMxjp1GvSOgnG+8mD1oSmODOFElA0+0vbHzVjbJVkCN4SOqXG5+bKkXX0 P/3x55pBI2FGacE9pA3Na/8ZaLm4mBZNHIL8CkIenkWaB11qgUF3SCZkJIUKvRlH Od06dogf/kuB5UzY0ylxKGgUlCM=
Received: by filter0229p1iad2.sendgrid.net with SMTP id filter0229p1iad2-29381-5C185B4B-46 2018-12-18 02:28:27.94916706 +0000 UTC m=+29319.220606322
Received: from github-lowworker-e711880.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0035p1iad2.sendgrid.net (SG) with ESMTP id UQAMBHstSKqyCNfG5X8LJA for <quic-issues@ietf.org>; Tue, 18 Dec 2018 02:28:27.800 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e711880.cp1-iad.github.net (Postfix) with ESMTP id C04B444078D for <quic-issues@ietf.org>; Mon, 17 Dec 2018 18:28:27 -0800 (PST)
Date: Tue, 18 Dec 2018 02:28:27 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9b3b93ebe346a9d67a14b6831e9d394dd830ae7292cf0000000118301d4b92a169ce1752fa68@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2187/review/185884412@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2187@github.com>
References: <quicwg/base-drafts/pull/2187@github.com>
Subject: Re: [quicwg/base-drafts] Allow alternate restarts after idle (#2187)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c185b4bbeeff_502e3fdbdacd45c44089f5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1gUsls60h2TmVDEVx63ViNmB9/4pgQ/qSgX2 fH6CX98MK1Y/exHNchX88N060NL4Yl7lt3cX6E1UHUjpyqQ1Yv/Ria6NYvVLrPxokQ3Bssef9uIbt/ 1kwUtagULvqdJgpSy8AaD+z9RPBdakpqGjBP0HOa+idlrzzOwWqMJYI/VD+Va/6jfolSUA0PAKC5WO w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bhOawzK7EAnG8-SWPqlVywcVh90>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 02:28:32 -0000

ianswett commented on this pull request.

This looks better, but I'm still a bit confused about the post-PTO case

> -application limited or after a probe timeout. In order to limit
-the size of bursts sent into the network, the behavior when restarting from
-idle depends upon whether pacing is used.
-
-If the sender uses pacing, the connection should limit the initial burst of
-packets to no more than the initial congestion window and subsequent packets
-SHOULD be paced. The congestion window does not change while the connection
-is idle.
-
-A sender that does not use pacing SHOULD reset its congestion window to the
-minimum of the current congestion window and the initial congestion window.
-This recommendation is based on Section 4.1 of {{?RFC5681}}.
+
+## Sending data after an idle period
+
+A sender is considered idle if it has no bytes in flight.  A sender can become

```suggestion
 A sender is idle if it has no bytes in flight.  A sender can become
```

> -idle depends upon whether pacing is used.
-
-If the sender uses pacing, the connection should limit the initial burst of
-packets to no more than the initial congestion window and subsequent packets
-SHOULD be paced. The congestion window does not change while the connection
-is idle.
-
-A sender that does not use pacing SHOULD reset its congestion window to the
-minimum of the current congestion window and the initial congestion window.
-This recommendation is based on Section 4.1 of {{?RFC5681}}.
+
+## Sending data after an idle period
+
+A sender is considered idle if it has no bytes in flight.  A sender can become
+idle when it is application limited and has no data to send, or when it marks
+packets as lost (and therefore not in flight).

Is this aiming at the PTO case?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2187#pullrequestreview-185884412