Re: [quicwg/base-drafts] Clarify that clients don't need to remember unknown SETTINGS (#3113)

Nick Harper <notifications@github.com> Tue, 22 October 2019 22:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D50A1200FB for <quic-issues@ietfa.amsl.com>; Tue, 22 Oct 2019 15:57:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DVI8X5OzHBAm for <quic-issues@ietfa.amsl.com>; Tue, 22 Oct 2019 15:57:18 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7F00B120111 for <quic-issues@ietf.org>; Tue, 22 Oct 2019 15:57:18 -0700 (PDT)
Received: from github-lowworker-6b40fdd.va3-iad.github.net (github-lowworker-6b40fdd.va3-iad.github.net [10.48.16.64]) by smtp.github.com (Postfix) with ESMTP id A9C0F6A0601 for <quic-issues@ietf.org>; Tue, 22 Oct 2019 15:57:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571785037; bh=eneKikQZ0Q0eijNhAfM7PcVia7W6/ikwktTFTYdixSY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vXAGzuee2LwVU/AqTho8uQYEFPxmunY02463BvAm0PdsJ96wHXx1lIZZjKAhLoQvN dpSMzQInW9tQwoWM191UP5WJqYK2bLoHPKyEHZJ2Il/O8ggq88bY3oqxp7fhCaYTX6 dc+uL9wmOC+jSo9uLT8PPIrGy7K4AxlTSeD9ywJ4=
Date: Tue, 22 Oct 2019 15:57:17 -0700
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6LEXAJLS4PJ56YAUF3XTE53EVBNHHB4UIFQY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3113/review/305553610@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3113@github.com>
References: <quicwg/base-drafts/pull/3113@github.com>
Subject: Re: [quicwg/base-drafts] Clarify that clients don't need to remember unknown SETTINGS (#3113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5daf894d99fe7_3f7b3ffc5f4cd95c642b9"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nharper
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6WalA8KRBw9Aa-1KI6hXDvKxcrg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 22:57:21 -0000

nharper commented on this pull request.



> @@ -1229,10 +1229,13 @@ A server MAY accept 0-RTT and subsequently provide different settings in its
 SETTINGS frame. If 0-RTT data is accepted by the server, its SETTINGS frame MUST
 NOT reduce any limits or alter any values that might be violated by the client
 with its 0-RTT data.  The server MUST include all settings which differ from
-their default values.  If a server accepts 0-RTT, but then sends a SETTINGS
-frame which reduces a setting the client understands or omits a value that was
-previously specified to have a non-default value, this MUST be treated as a
-connection error of type HTTP_SETTINGS_ERROR.
+their default values.  If a server accepts 0-RTT but then sends a SETTINGS
+frame which reduces setting the client understands, this MUST be treated as a

Thanks for catching the missing "a" in "reduces a setting" (although it's moot now that I've reworded this).

I like using the term "compatible" instead of reduces, since it avoids this odd edge case and imo is more specific.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3113#discussion_r337785586