Re: [quicwg/base-drafts] Clarify that clients don't need to remember unknown SETTINGS (#3113)

Mike Bishop <notifications@github.com> Tue, 22 October 2019 22:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0297C1200FD for <quic-issues@ietfa.amsl.com>; Tue, 22 Oct 2019 15:09:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Osr8g6SoD7Kp for <quic-issues@ietfa.amsl.com>; Tue, 22 Oct 2019 15:09:50 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EB3E12001A for <quic-issues@ietf.org>; Tue, 22 Oct 2019 15:09:50 -0700 (PDT)
Date: Tue, 22 Oct 2019 15:09:49 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571782189; bh=+knZFXkK2hNq0ruo3RjJ4p+LCy8/pHqa0Y9tfpDTL4c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YzJbj41z+038D5Cvs2t4ULw1B6Tg1mzgMCZPO1J7bH3i8Q5K+T9ZGJ1y0cLCkGjPE UjrcwYu868yYXUzPWqEyH80IJfmnXaZSToRbW1YHz9v+psC3LACSP+L1OkU6QA2DSN M3E0JRjMOCwzZ/aCUUmqG2aAgKPXAPJclsVbHKao=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYHAGIXOXJNBEF5QE53XS7L3EVBNHHB4UIFQY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3113/review/305537897@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3113@github.com>
References: <quicwg/base-drafts/pull/3113@github.com>
Subject: Re: [quicwg/base-drafts] Clarify that clients don't need to remember unknown SETTINGS (#3113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5daf7e2d5e155_28f93fa210ecd960980081"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zIvkX0eVPgAZOSv3Dv0lhL5BQYQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 22:09:52 -0000

MikeBishop commented on this pull request.



> @@ -1229,10 +1229,13 @@ A server MAY accept 0-RTT and subsequently provide different settings in its
 SETTINGS frame. If 0-RTT data is accepted by the server, its SETTINGS frame MUST
 NOT reduce any limits or alter any values that might be violated by the client
 with its 0-RTT data.  The server MUST include all settings which differ from
-their default values.  If a server accepts 0-RTT, but then sends a SETTINGS
-frame which reduces a setting the client understands or omits a value that was
-previously specified to have a non-default value, this MUST be treated as a
-connection error of type HTTP_SETTINGS_ERROR.
+their default values.  If a server accepts 0-RTT but then sends a SETTINGS
+frame which reduces setting the client understands, this MUST be treated as a

reduces "a" setting.  #2972 switched to using the term "compatible" up at lines 1215-1216, including a definition of the term; perhaps using "incompatible" instead of "reduces" here as well would help?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3113#discussion_r337773294