Re: [quicwg/base-drafts] Added more text to NCID section (#3535)

Nick Banks <notifications@github.com> Fri, 20 March 2020 03:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B7F33A150A for <quic-issues@ietfa.amsl.com>; Thu, 19 Mar 2020 20:03:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.554
X-Spam-Level:
X-Spam-Status: No, score=-1.554 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 29SzD_cKGFCu for <quic-issues@ietfa.amsl.com>; Thu, 19 Mar 2020 20:03:37 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C36F13A1508 for <quic-issues@ietf.org>; Thu, 19 Mar 2020 20:03:36 -0700 (PDT)
Received: from github-lowworker-c5134a3.ac4-iad.github.net (github-lowworker-c5134a3.ac4-iad.github.net [10.52.23.55]) by smtp.github.com (Postfix) with ESMTP id 64E6A1C0A02 for <quic-issues@ietf.org>; Thu, 19 Mar 2020 20:03:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584673415; bh=4na7xkQzFRr/ohN/l8BYQtbiX2yrGB33P4C3Hlo9/Yw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RJJBTvp3IF1hmdYy4qyZ23MWg8UHybKOT+QIRiS4NQHjIj+Cnc++NKuzFrE07M19j V3zQZ76kY4cyQeGiAavPOtyIKhs/I7p4B1TG3cGdmfq2pp7sZOzSsJcu78SfkXWd8b gIrrmZJxIHtqouFKTRTE79SWAudXqOb2b1d7OsoQ=
Date: Thu, 19 Mar 2020 20:03:35 -0700
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5Q7VO5ECBFHRGCLT54QAJYPEVBNHHCFWTUEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3535/review/378211773@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3535@github.com>
References: <quicwg/base-drafts/pull/3535@github.com>
Subject: Re: [quicwg/base-drafts] Added more text to NCID section (#3535)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e74328751140_4b0d3fe52aacd95c484f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AP9FsHjFsc8FKUcAdeVmysvnhCg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Mar 2020 03:03:39 -0000

nibanks approved this pull request.

Looks fine to me, though I do think it's better with some kind of language to send it sooner rather than later.

> @@ -5578,9 +5578,9 @@ value.
 
 An endpoint that receives a NEW_CONNECTION_ID frame with a sequence number
 smaller than the Retire Prior To field of a previously received
-NEW_CONNECTION_ID frame MUST immediately send a corresponding
-RETIRE_CONNECTION_ID frame that retires the newly received connection ID.
-
+NEW_CONNECTION_ID frame MUST send a corresponding RETIRE_CONNECTION_ID frame

"promptly send"? Though that's almost the same as immediately.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3535#pullrequestreview-378211773