Re: [quicwg/base-drafts] Added more test to NCID section (#3535)

martinduke <notifications@github.com> Fri, 20 March 2020 00:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0A703A1348 for <quic-issues@ietfa.amsl.com>; Thu, 19 Mar 2020 17:33:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id chF3mtzIJeOH for <quic-issues@ietfa.amsl.com>; Thu, 19 Mar 2020 17:33:28 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 508483A133D for <quic-issues@ietf.org>; Thu, 19 Mar 2020 17:33:14 -0700 (PDT)
Received: from github-lowworker-1dbcc59.ash1-iad.github.net (github-lowworker-1dbcc59.ash1-iad.github.net [10.56.105.54]) by smtp.github.com (Postfix) with ESMTP id 96AA12C0E55 for <quic-issues@ietf.org>; Thu, 19 Mar 2020 17:33:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584664393; bh=c9UfbNrFmCz37ua/pcEZHX8U7lVqRGfZdKyWyFszc7I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MtiudM+QCVHgfWYUEggwwAT9RMAcuVH9IkdDor7cOnO+RXjKwm4MrrpWtzkD+Z7Gv k0tBzJjpeV/ktdEE/ieUv4lIzezkPslXMW4dH/nLpY7RsjYQbqQeIeL4X01PFU27nV JkPyBNQ/D83RWjW2nrTu0A8JkW8Z0J5Kyui5NksU=
Date: Thu, 19 Mar 2020 17:33:13 -0700
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6ACTQE4DTJKZKFJMN4P7YETEVBNHHCFWTUEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3535/review/378180140@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3535@github.com>
References: <quicwg/base-drafts/pull/3535@github.com>
Subject: Re: [quicwg/base-drafts] Added more test to NCID section (#3535)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e740f4988395_78673f7e4e6cd96c146162"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hckar8_FfPXArDq_KNBV3PyGFmc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Mar 2020 00:33:39 -0000

martinduke commented on this pull request.



> @@ -5579,8 +5585,8 @@ value.
 An endpoint that receives a NEW_CONNECTION_ID frame with a sequence number
 smaller than the Retire Prior To field of a previously received
 NEW_CONNECTION_ID frame MUST immediately send a corresponding
-RETIRE_CONNECTION_ID frame that retires the newly received connection ID.
-
+RETIRE_CONNECTION_ID frame that retires the newly received connection ID,
+unless it has already done so for that sequence number.

@erickinnear The multiple times part.
@martinthomson good suggestion; I will patch it after I make dinner.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3535#discussion_r395391470