IETF Logo Mail Archive

Re: [quicwg/base-drafts] Repeat tokens in all Initial packets (#2089)

MikkelFJ <notifications@github.com> Mon, 03 December 2018 20:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0CB10130DC4 for <quic-issues@ietfa.amsl.com>; Mon, 3 Dec 2018 12:25:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dDs6QutVIH8b for <quic-issues@ietfa.amsl.com>; Mon, 3 Dec 2018 12:25:44 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D406412DDA3 for <quic-issues@ietf.org>; Mon, 3 Dec 2018 12:25:43 -0800 (PST)
Date: Mon, 03 Dec 2018 12:25:43 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543868743; bh=9Rjtrvrqc+3ozG7Euxu0xHLhlBCqLEDFRUenq88VKVw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OQeykSQDASh9B4nuDXm2fjYZy0v1/x+BJ61q2bh81ETH6vSYGvAp7+EnzNR6T/Dyg m3aUELDnaxlx4LkPIwdTggNyOjsSr7iql7yVIIYX4pKg/rjDnHI240zw3VtgwuPiad WgL0xeTLCRtii/SbWdxhWuHLRP7h0o3yyXdqZ2us=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0df5dbff3c5a24b35b5292d0b0ce90d293ce394d92cf00000001181d534792a169ce17097d1f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2089/review/180962882@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2089@github.com>
References: <quicwg/base-drafts/pull/2089@github.com>
Subject: Re: [quicwg/base-drafts] Repeat tokens in all Initial packets (#2089)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c059147ba2a_71f03f97290d45bc209867"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BKGC7M93hJMa9b_UvXn4PUiQYP0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2018 20:25:47 -0000

mikkelfj commented on this pull request.



> @@ -1548,9 +1548,9 @@ frame (see {{validate-future}}).
 
 Upon receiving the client's Initial packet, the server can request address
 validation by sending a Retry packet ({{packet-retry}}) containing a token. This
-token MUST be repeated by the client in all Initial packets it sends after it receives the
-Retry packet.  In response to receiving a token in an Initial packet, a server
-can either abort the connection or permit it to proceed.
+token MUST be repeated by the client in all Initial packets it sends after it
+receives the Retry packet.  In response to receiving a token in an Initial
+packet, a server can either abort the connection or permit it to proceed.
 

Isn't there a third option to ignore a packet rather then abort or permit to proceed?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2089#pullrequestreview-180962882

v2.23.0 | Report a Bug | By Email