IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make in_flight the criterion for declaring loss (#2104)

Nick Banks <notifications@github.com> Fri, 07 December 2018 15:10 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DCD1E12D4EB for <quic-issues@ietfa.amsl.com>; Fri, 7 Dec 2018 07:10:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cdV9lfZN_Y_L for <quic-issues@ietfa.amsl.com>; Fri, 7 Dec 2018 07:10:17 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 88AE2126CC7 for <quic-issues@ietf.org>; Fri, 7 Dec 2018 07:10:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=9aA2Dm3WPzN5Re745HL9xf8H3Fg=; b=B36M4OFsOoArxmX0 I0IiwcBSF3w4POkjA9Au+f0x9XO+2MKDRfYVAeJYeQRKYBOd1jiAkiOkP56A8Zia O/HAsjikb6cHs/9zNFBXOK4dCTx9dnFlau3fJNzQp41J8d3XCo4zIm5hnI5L5VYJ Ncj9HvvpuULm2lMp6NBVNy12FcQ=
Received: by filter0416p1iad2.sendgrid.net with SMTP id filter0416p1iad2-31917-5C0A8D58-50 2018-12-07 15:10:16.329845944 +0000 UTC m=+77335.866460166
Received: from github-lowworker-89d05ac.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0001p1iad2.sendgrid.net (SG) with ESMTP id CyI8qhkpQami5JzNTLJCHA for <quic-issues@ietf.org>; Fri, 07 Dec 2018 15:10:16.347 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-89d05ac.cp1-iad.github.net (Postfix) with ESMTP id 44850AE02D7 for <quic-issues@ietf.org>; Fri, 7 Dec 2018 07:10:16 -0800 (PST)
Date: Fri, 07 Dec 2018 15:10:16 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5753ff1a35c89b6e4319ff9e0dd73970401661ac92cf0000000118224f5892a169ce172626a9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2104/c445261559@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2104@github.com>
References: <quicwg/base-drafts/pull/2104@github.com>
Subject: Re: [quicwg/base-drafts] Make in_flight the criterion for declaring loss (#2104)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c0a8d5842f93_49ca3ff8006d45c42036fd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2KzngVjvR1QdRtqFnmOto/pegwgeXxjculel WtEkBw47W7wW9nUTnZ7IuY+6lItL9SRinQ2ZzsT8lY9ZQHYCDM5rJKux/FKPH/PKnWau01zOkYaUUE hrgEwsVdwwAj843IIvWSTS6I2vl7AY9aA8QhvzRm0eqgBZEDPBevGAvTsTevP616MiAO1Nn+3ZGR/g o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BwpptEDs3Pu4ZAhzMYF04Dskmzk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Dec 2018 15:10:20 -0000

I feel like this is somewhat related to my issue (#2015) related to calling `OnPacketsLost` for all lost packets, not just retransmittable/ack-eliciting ones. If you know the packet was lost, then process it as such. Now, what you do it response to it being lost is where you would then put the `in_flight` check for removing the `bytes_in`flight` and whatever other logic.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2104#issuecomment-445261559

v2.23.0 | Report a Bug | By Email