IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make in_flight the criterion for declaring loss (#2104)

ianswett <notifications@github.com> Thu, 06 December 2018 22:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1BDC0130F35 for <quic-issues@ietfa.amsl.com>; Thu, 6 Dec 2018 14:46:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h0iugxPruBGm for <quic-issues@ietfa.amsl.com>; Thu, 6 Dec 2018 14:46:08 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 34684130F09 for <quic-issues@ietf.org>; Thu, 6 Dec 2018 14:46:08 -0800 (PST)
Date: Thu, 06 Dec 2018 14:46:07 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544136367; bh=8AQ44UwA69/6ebgTiJou0R6NsCFapuo0wH/gyF8esDQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hglD8SevdeubuBl9ohneIu4AwWQXemW2bQD+mZsbumZX923uE6IRZ2Um1PCpy1TdJ FoYT5K5tUS9tXM1XHcliv2dI90juejSeXXl6luEqf3os+UCyvmkZFsoIVzPVBT14WQ 0xaYfGUVia/InVTww3DC5g/fbCpBoCHwUAHlTz2M=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab867927a27f51b1c03f3167544958b2c204e4944692cf00000001182168af92a169ce172626a9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2104/review/182484226@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2104@github.com>
References: <quicwg/base-drafts/pull/2104@github.com>
Subject: Re: [quicwg/base-drafts] Make in_flight the criterion for declaring loss (#2104)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c09a6af2935b_65013fa87b2d45c0173115"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3_9Cm9XAUh376pfWjGjYKiPfOtY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2018 22:46:10 -0000

ianswett commented on this pull request.

This pseudocode is also being updated in PR#2066, but you're correct that it should be in_flight, not retransmittable.

>  
-* The packet is unacknowledged, retransmittable, and was sent prior to an
-  acknowledged packet.
+* The packet is in-flight, and was sent prior to an acknowledged packet.

Did you intend to drop "unacknowledged"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2104#pullrequestreview-182484226

v2.23.0 | Report a Bug | By Email