Re: [quicwg/base-drafts] create codec streams only when necessary (#2090)

[Kazuho Oku <[e-mail]>]

@martinthomson 
> Let me try to expand on my earlier comment. I currently create these streams when building my connection object. This allows requests and responses to use those streams directly. If the streams might not exist, then I have to allow those values to be absent throughout, which is annoying but not a big deal. More of a concern is that this is concurrent code, so deferring creation would mean that I would have to guard the variables holding the streams with a mutex (or atomic, which always gives me the creeps). That creates the potential for contention point on every new message.

Isn't it the case that you would be having contention point even without the proposed change, assuming that you are creating the connection object prior to receiving the SETTINGS frame? I ask this because the receipt of SETTINGS_MAX_TABLE_SIZE updates the state of the QPACK encoder.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2090#issuecomment-446831416