Re: [quicwg/base-drafts] Compare H2 PROTOCOL_ERROR with HTTP_GENERAL_PROTOCOL_ERROR (#2808)

Kazuho Oku <notifications@github.com> Wed, 19 June 2019 13:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 98DC6120480 for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 06:13:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.02
X-Spam-Level:
X-Spam-Status: No, score=-7.02 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.415, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oGtf5E_WlqfB for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 06:13:43 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E1E7C12032D for <quic-issues@ietf.org>; Wed, 19 Jun 2019 06:13:42 -0700 (PDT)
Date: Wed, 19 Jun 2019 06:13:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560950021; bh=yY4GiKOgBNNFK9aOwFuM8Lwgx4cLO5803l0kAt5Q/wM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rauAJPQzkFIHKaJmmlhQ8vHJon1mmP28eee0zAlKb4k8H6TDZbFsvCP5ccFVTMH74 WmHdz7GVwgRTw+h9ZZ32jYgeR8ETBJNvffBL4rqvwtNlEDW140+EP+rjrpf+hdRg0y SUBC02+Lo5zdxd2RZOyQyjnunjCGIP3ZvgvvDgtQ=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4MTHJU65FSBDDQGAV3C5TYLEVBNHHBWS37GE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2808/review/251688506@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2808@github.com>
References: <quicwg/base-drafts/pull/2808@github.com>
Subject: Re: [quicwg/base-drafts] Compare H2 PROTOCOL_ERROR with HTTP_GENERAL_PROTOCOL_ERROR (#2808)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0a3505de59a_79853ff61c4cd9641277db"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EU_oAEHuOJ0WT24rdpp22-aSP-E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2019 13:13:45 -0000

kazuho commented on this pull request.



> @@ -2174,8 +2174,7 @@ NO_ERROR (0x0):
 : HTTP_NO_ERROR in {{http-error-codes}}.
 
 PROTOCOL_ERROR (0x1):
-: No single mapping.  See new HTTP_MALFORMED_FRAME error codes defined in
-  {{http-error-codes}}.
+: HTTP_GENERAL_PROTOCOL ERROR in {{http-error-codes}}.

Maybe I should have stated that the removal of "No single mapping." is concerning, because IIUC we do not have one-to-one mapping between PROTOCOL_ERROR (of HTTP/2) and HTTP_GENEAL_PROTOCOL error (of HTTP/3).

What I had in mind is something like "Split into a few error codes, including HTTP_GENERAL_PROTOCOL, HTTP_WRONG_STREAM, HTTP_UNEXPECTED_FRAME, HTTP_CLOSED_CRITICAL_STREAM."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2808#discussion_r295289124