Re: [quicwg/base-drafts] Interaction of FIN and message parsing (#2003)

Kazuho Oku <notifications@github.com> Wed, 28 November 2018 01:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF238130DEC for <quic-issues@ietfa.amsl.com>; Tue, 27 Nov 2018 17:29:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RFt23LC_uvQY for <quic-issues@ietfa.amsl.com>; Tue, 27 Nov 2018 17:29:01 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4773F12875B for <quic-issues@ietf.org>; Tue, 27 Nov 2018 17:29:01 -0800 (PST)
Date: Tue, 27 Nov 2018 17:29:00 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543368540; bh=lfHghKeCZGgTPYgrDIn5mrcl0Tk2KKkedZDCr5ySHvk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=nRLeCfJPlVSZnpjM5uv9ttB8xLekMxrPHdc6fVWukayI4zerAS48rMuIHhEPDxzHH LeSjtIzV6xJ590+bVvonv4Pdb+h+Q5d1B+ZHW7XK4npT41xPqHe9c+qERRYocLg6pF 4KVMkLS+1NXu0DvRNoDt8/0j8RBnvnK+lTe/2yro=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abca7c1455b6f30f054b69bc875714ab9721972cfc92cf000000011815b15c92a169ce16b355af@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2003/review/179088319@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2003@github.com>
References: <quicwg/base-drafts/pull/2003@github.com>
Subject: Re: [quicwg/base-drafts] Interaction of FIN and message parsing (#2003)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfdef5c76243_631e3fd35fad45b8218417"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Gbz1SzwQAA56JQG13T8ceRJYSkQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2018 01:29:03 -0000

kazuho commented on this pull request.



>  
 A response MAY consist of multiple messages when and only when one or more
 informational responses (1xx, see {{!RFC7231}}, Section 6.2) precede a final
 response to the same request.  Non-final responses do not contain a payload body
 or trailers.
 
 An HTTP request/response exchange fully consumes a bidirectional QUIC stream.
-After sending a request, a client closes the stream for sending; after sending a
-final response, the server closes the stream for sending and the QUIC stream is
-fully closed.  Requests and responses are considered complete when the
-corresponding QUIC stream is closed in the appropriate direction.
+After sending a request, a client MUST close the stream for sending; clients
+MUST NOT make stream closure dependent on receiving a response to their request,
+unless using the CONNECT method (see {{the-connect-method}}). After sending a

This sentence is confusing to me, because it is unclear what "unless" applies to.

How about changing the sentence to: _Unless using the CONNECT method (see {{the-connect-method}}), a client MUST close the stream for sending after sending a request. Clients MUST NOT make stream closure dependent on receiving a response to the request._

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2003#pullrequestreview-179088319