Re: [quicwg/base-drafts] Don't wait for FIN to process complete messages (#2003)

Kazuho Oku <notifications@github.com> Mon, 19 November 2018 22:24 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8DF701252B7 for <quic-issues@ietfa.amsl.com>; Mon, 19 Nov 2018 14:24:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PU89B6tXMdkV for <quic-issues@ietfa.amsl.com>; Mon, 19 Nov 2018 14:24:30 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D3C9E124408 for <quic-issues@ietf.org>; Mon, 19 Nov 2018 14:24:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Hk3O369v/qLtzmNaKmrqE9M4bMU=; b=Py2P+tjGhstIRyhi MLFiXzl/7VeZ0oBPWIIxUSZNXJCekoN5peK7R1GzIW4NnfVl5Hut/GW0Wtz7O6Jj q5StnFEmN6oPx+8yflo1rf65aN/nXz+o8iCP6bfaIaDWmyEC6K9scQdTXIVhu23i dS6oL7xtVOilLk2C95oti/Seeac=
Received: by filter0804p1las1.sendgrid.net with SMTP id filter0804p1las1-19710-5BF3381C-4 2018-11-19 22:24:28.220564036 +0000 UTC m=+282395.009974775
Received: from github-lowworker-4f62d42.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0009p1iad2.sendgrid.net (SG) with ESMTP id BTnh8xCgSM-1OvnHiOuqhA for <quic-issues@ietf.org>; Mon, 19 Nov 2018 22:24:27.995 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-4f62d42.cp1-iad.github.net (Postfix) with ESMTP id 05EBFC00EF for <quic-issues@ietf.org>; Mon, 19 Nov 2018 14:24:28 -0800 (PST)
Date: Mon, 19 Nov 2018 22:24:28 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab36afc8feaf7448573cb18bee3dc55e98191943e392cf00000001180afa1c92a169ce16b355af@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2003/review/176525139@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2003@github.com>
References: <quicwg/base-drafts/pull/2003@github.com>
Subject: Re: [quicwg/base-drafts] Don't wait for FIN to process complete messages (#2003)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf3381c47f2_46153fa9db2d45b414316a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak39O9W4anCjPWaUpGWCQ762euvoyvpzJYvFLX ipTi+CP8LZj4m7Eu2Gur2tHQHIQNt3Y9udYKmg0Y92jLQBO9ZkibSWy2JHzoqpiWw2BqNEWrZGVyx6 ZQVQk10wR6Rd5TPGnKNn6hVyjqO4xAFKOVOE+pF92cdryaK18hwKqxqYg4mzDRfCFBmf82cu+5ksln k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WA1C2GMbap505dikL7L7XTWFnc8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Nov 2018 22:24:32 -0000

kazuho commented on this pull request.



>  
 A response MAY consist of multiple messages when and only when one or more
 informational responses (1xx, see {{!RFC7231}}, Section 6.2) precede a final
 response to the same request.  Non-final responses do not contain a payload body
 or trailers.
 
 An HTTP request/response exchange fully consumes a bidirectional QUIC stream.
-After sending a request, a client closes the stream for sending; after sending a
-final response, the server closes the stream for sending and the QUIC stream is
-fully closed.  Requests and responses are considered complete when the
-corresponding QUIC stream is closed in the appropriate direction.
+After sending a request, a client SHOULD close the stream for sending; after
+sending a final response, the server SHOULD close the stream for sending. At

I think we need to use "MUST" here. Otherwise, a peer can never notice the end of the message unless trailers are used.

Other than that, the PR looks good to me. I like the language that encourages endpoints to start processing early.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2003#pullrequestreview-176525139