Re: [quicwg/base-drafts] Interaction of FIN and message parsing (#2003)

Mike Bishop <notifications@github.com> Mon, 26 November 2018 17:30 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAC46130DC9 for <quic-issues@ietfa.amsl.com>; Mon, 26 Nov 2018 09:30:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G9PW_E8L_izx for <quic-issues@ietfa.amsl.com>; Mon, 26 Nov 2018 09:30:13 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE950130DC0 for <quic-issues@ietf.org>; Mon, 26 Nov 2018 09:30:13 -0800 (PST)
Date: Mon, 26 Nov 2018 09:30:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543253412; bh=qZ8pS5JXgFz5qBakK8vjZYQog1XZ3ZJBQ61+2K84JXY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=P/FTUF+CiH0fLanAW2GsT/1zDmJtVOXok43qtw41o/xhnYg9KTev4xRE40y59X/1H vqZT22qHEoMLPvD8QxLt0w20cyCy2ZUbwTBJkF5nvUQfnYAubZliy38mKLJO4QmlUb bxboDy/stzybKHRL5o31/LSjZv32yjqDnm9TXtpw=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf6d69f02cf025f38d90bfa12f25cb6e5e1cc015792cf000000011813efa492a169ce16b355af@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2003/review/178410195@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2003@github.com>
References: <quicwg/base-drafts/pull/2003@github.com>
Subject: Re: [quicwg/base-drafts] Interaction of FIN and message parsing (#2003)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfc2da4be786_7fd3fbdd02d45c460852d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/P1ri9GJn0krNgNqDCu6ALyBkUNc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Nov 2018 17:30:16 -0000

MikeBishop commented on this pull request.



>  
 A response MAY consist of multiple messages when and only when one or more
 informational responses (1xx, see {{!RFC7231}}, Section 6.2) precede a final
 response to the same request.  Non-final responses do not contain a payload body
 or trailers.
 
 An HTTP request/response exchange fully consumes a bidirectional QUIC stream.
-After sending a request, a client closes the stream for sending; after sending a
-final response, the server closes the stream for sending and the QUIC stream is
-fully closed.  Requests and responses are considered complete when the
-corresponding QUIC stream is closed in the appropriate direction.
+After sending a request, a client MUST close the stream for sending; after
+sending a final response, the server MUST close the stream for sending. At
+this point, the QUIC stream is fully closed.

Yeah, the original provoking issue was that he didn't FIN, the server didn't respond, and both are doing totally spec-compliant things.  With this language, it's at least clarified that while the server SHOULD process that request on receipt, it isn't required to until the stream closes, so the client needs to close promptly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2003#discussion_r236352508