Re: [quicwg/base-drafts] Why do we have final size? (#3739)

[Kazuho Oku <[e-mail]>]

@kazuho commented on this pull request.

:+1: LGTM modulo a nitpick.

> @@ -908,10 +908,13 @@ final size is the number of bytes sent.  More generally, this is one higher
 than the offset of the byte with the largest offset sent on the stream, or zero
 if no bytes were sent.
 
-For a stream that is reset, the final size is carried explicitly in a
-RESET_STREAM frame.  Otherwise, the final size is the offset plus the length of
-a STREAM frame marked with a FIN flag, or 0 in the case of incoming
-unidirectional streams.
+The final size of a stream is always signaled to the recipient.  The final size
+is the sum of the Offset and Length fields of a STREAM frame with a FIN flag,
+noting that the length might be implicit.  Alternatively, the Final Size field

Maybe "noting that the offset and the length might be implicit"?

This is an editorial nitpick purely from the viewpoint of consistency, but it is a bit surprising to see only one of the two fields called out as might be implicit, even though both of the fields can be omitted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3739#pullrequestreview-426312353