IETF Logo Mail Archive

Re: [quicwg/base-drafts] Capitalization and Consistency (PR #4989)

Mike Bishop <notifications@github.com> Wed, 11 May 2022 14:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6CD63C15E6F1 for <quic-issues@ietfa.amsl.com>; Wed, 11 May 2022 07:18:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.26
X-Spam-Level:
X-Spam-Status: No, score=-2.26 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.575, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z1oMr-WVIN8j for <quic-issues@ietfa.amsl.com>; Wed, 11 May 2022 07:18:08 -0700 (PDT)
Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C7965C159482 for <quic-issues@ietf.org>; Wed, 11 May 2022 07:18:08 -0700 (PDT)
Received: from github-lowworker-d92125f.va3-iad.github.net (github-lowworker-d92125f.va3-iad.github.net [10.48.121.72]) by smtp.github.com (Postfix) with ESMTP id E30E3840076 for <quic-issues@ietf.org>; Wed, 11 May 2022 07:18:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1652278687; bh=r8jFPr8DzSmUATA/6+bMh+61KXEdvXOByjZbB/zV0kM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=e39ZUfTrETy79ovpC2ZTW9twk0JFkk5jVNe7/XlIMYlqh3uXLqtnlx2K1WDB+7I9x Hr5Rk2+Kg/REryN5KqeBv63t0MTux/R84kwK/trTxSM2R90JhF3fjwYZPdCJMHhq2+ e84Q2DbhkswtAq6lSkYnF2E9vk13Ti9Jnvsygfe4=
Date: Wed, 11 May 2022 07:18:07 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4UO4NQ6IVOMWL76Z6ARD4B7EVBNHHES2CVWA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4989/review/969450414@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4989@github.com>
References: <quicwg/base-drafts/pull/4989@github.com>
Subject: Re: [quicwg/base-drafts] Capitalization and Consistency (PR #4989)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_627bc59fd4b01_1191d4086613bc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/L6_X-BwSQYihlbQiuxLpwHGzyNc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.34
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2022 14:18:09 -0000

@MikeBishop commented on this pull request.



>  
 The value of Base MUST NOT be negative. Though the protocol might operate
-correctly with a negative base using post-base indexing, it is unnecessary and
-inefficient. An endpoint MUST treat a field block with an S bit of 1 as invalid
-if the value of Required Insert Count is less than or equal to the value of
-Delta Base.
+correctly with a negative Base using post-Base indexing, it is unnecessary and
+inefficient. An endpoint MUST treat a field block with a sign bit of 1 as

"sign bit" is lower-case elsewhere, and is introduced with "one-bit sign ('S')" at the first reference in each section.  I'm open to changing it so that the field is called "Sign" and "S" is merely the representation in the diagram, but that's a (slightly) larger change.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4989#discussion_r870362663
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4989/review/969450414@github.com>

v2.23.0 | Report a Bug | By Email