Re: [quicwg/base-drafts] The "quic " label is used for key update (#1899)

janaiyengar <notifications@github.com> Tue, 23 October 2018 23:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 180DE127AC2 for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 16:41:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8gY13ZTW1uh2 for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 16:41:16 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7DD0A130DC6 for <quic-issues@ietf.org>; Tue, 23 Oct 2018 16:41:16 -0700 (PDT)
Date: Tue, 23 Oct 2018 16:41:15 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540338075; bh=PgLYE+FciZNWQVVuk7CJrtFmNa6NU7lrg21Wp+3t1gY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TCHqgyiWGf6Qdm7haNcor38Bh6XUQNhwUy71LmX5I36eXAO3OhwvQ3MW1PFS/nzXQ M8pTrl3mjGyLsBuPYAkDM84E7g2Rqe8wTeambcwGsAtTXDknx6iE+iS/66F89YjATP T7434B7jFMYVUDWYkzK7a8sbgc5GQLuC574miJfU=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab78eac6cdb65f8ebdca0cbe81eb5109283a4384c392cf0000000117e7739b92a169ce163f3039@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1899/review/167681460@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1899@github.com>
References: <quicwg/base-drafts/pull/1899@github.com>
Subject: Re: [quicwg/base-drafts] The "quic " label is used for key update (#1899)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bcfb19bd1ba7_7ecb3f801acd45b86544c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/My5cgk2l_OIev67LQwWSdeMy8x0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 23:41:18 -0000

janaiyengar commented on this pull request.



> -
-An endpoint doesn't need to send packets immediately when it detects that its
-peer has updated keys.  The next packet that it sends will simply use the new
-keys.  If an endpoint detects a second update before it has sent any packets
-with updated keys it indicates that its peer has updated keys twice without
-awaiting a reciprocal update.  An endpoint MUST treat consecutive key updates as
-a fatal error and abort the connection.
+the corresponding read key and IV.  This uses the same variation on HKDF as
+defined in {{protection-keys}}; that is, the prefix "quic " is used in place of
+"tls13 ".
+
+If the packet can be decrypted and authenticated using the updated key and IV,
+then the keys the endpoint uses for packet protection are also updated.  The
+next packet sent by the endpoint will then use the new keys.
+
+An endpoint doesn't always need to send packets when it detects that its peer

```suggestion
An endpoint does not always need to send packets when it detects that its peer
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1899#pullrequestreview-167681460