Re: [quicwg/base-drafts] The "quic " label is used for key update (#1899)

janaiyengar <notifications@github.com> Tue, 23 October 2018 23:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C45E8130E53 for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 16:39:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gydPbMTYBuZp for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 16:39:13 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8771B127AC2 for <quic-issues@ietf.org>; Tue, 23 Oct 2018 16:39:13 -0700 (PDT)
Date: Tue, 23 Oct 2018 16:39:12 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540337952; bh=7Sr/yH4KgIHVbPAZl0gTbReedJhB38lRhUIHnY5hmNU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=myPjauViOH6JrH3ekVTAF0LO1D6l4Zhx12kUwWS4XfxjnVc5AyhX/JJEqUvct2Kwp VKkfA/+e8qXuYAFBS+JK2UvnHz1b1vlm1NfWKnSY+I61mPHzL8fwZ8PeIYq9KDFj9q 5QH96Uoi/5mItqPlV/12oPnQG74FnLwlea13L+vo=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab524abe3affa2fa2f917c0322d03c1090ec96275f92cf0000000117e7732092a169ce163f3039@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1899/review/167681004@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1899@github.com>
References: <quicwg/base-drafts/pull/1899@github.com>
Subject: Re: [quicwg/base-drafts] The "quic " label is used for key update (#1899)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bcfb120c255c_28633fba2b2d45b86577f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/b7SKX7cr3wizHEMpTQiupNhUwIM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 23:39:16 -0000

janaiyengar commented on this pull request.



> @@ -983,23 +983,31 @@ without necessarily needing to receive the first packet that triggered the
 change.  An endpoint that notices a changed KEY_PHASE bit can update keys and
 decrypt the packet that contains the changed bit.
 
+This mechanism replaces the TLS KeyUpdate message.  Endpoints MUST NOT send a
+TLS KeyUpdate message.  Endpoints MUST treat the receipt of a TLS KeyUpdate
+message as a connection error of type 0x10a, equivalent to a fatal TLS alert of
+unexpected_message (see {{tls-errors}}).
+
 An endpoint MUST NOT initiate more than one key update at a time.  A new key
 cannot be used until the endpoint has received and successfully decrypted a
 packet with a matching KEY_PHASE.
 
 A receiving endpoint detects an update when the KEY_PHASE bit doesn't match what

```suggestion
A receiving endpoint detects an update when the KEY_PHASE bit does not match what
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1899#pullrequestreview-167681004