Re: [quicwg/base-drafts] The "quic " label is used for key update (#1899)

janaiyengar <notifications@github.com> Tue, 23 October 2018 23:40 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5A778127AC2 for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 16:40:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.47
X-Spam-Level:
X-Spam-Status: No, score=-3.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n9euioSGditN for <quic-issues@ietfa.amsl.com>; Tue, 23 Oct 2018 16:40:15 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6B942130DC6 for <quic-issues@ietf.org>; Tue, 23 Oct 2018 16:40:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=fqYINViHyHsCgqLNJ0RrEl7ov5Q=; b=uQHHSE0StHqyUw8F 5YwohQU5SQ34djxbfx6Y0MIw0T1kX3H0zdDR/dyzAa8AFwX48jPcQyizEnWyumbt yiRSmh1HUX1CiLvprt0tfj54F01+1UO1MDrtg2skKnXoMBcpKLZSRCbZyzSIZb0v 0iCXhHvx+y9HZ8l9HoisgldUoOY=
Received: by filter1597p1mdw1.sendgrid.net with SMTP id filter1597p1mdw1-11617-5BCFB15D-25 2018-10-23 23:40:13.621269271 +0000 UTC m=+436007.748686269
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0006p1iad2.sendgrid.net (SG) with ESMTP id rcYbCy5lQV2KMDBdTsO9tw for <quic-issues@ietf.org>; Tue, 23 Oct 2018 23:40:13.573 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id 87EEB80B3A for <quic-issues@ietf.org>; Tue, 23 Oct 2018 16:40:13 -0700 (PDT)
Date: Tue, 23 Oct 2018 23:40:13 +0000
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab33d22dababb191b65c7eefe00884432553e0787092cf0000000117e7735d92a169ce163f3039@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1899/review/167681218@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1899@github.com>
References: <quicwg/base-drafts/pull/1899@github.com>
Subject: Re: [quicwg/base-drafts] The "quic " label is used for key update (#1899)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bcfb15d8603e_18173fd0608d45bc762e5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3NfeRPZBHQWGD49xXqNbKl8OhbJo3+F8ldgX iM3X1oiU4TbPdUTEvStJrxP4jQUJA3GkTshvv61BK5h6/KxEia0HrTVjeWDl3Pj834U56KsNI2hC7r nQQ7ro2cMvI5ExMBnK6i5xhfW3u9FdDoQ292fDpXshxSVAbaDu/YKDY2rt/lejL2XU8eZS/63pAw8W 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PJX8YtGTyOwgIq_9uYSxC3mzH6k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 23:40:19 -0000

janaiyengar commented on this pull request.



>  An endpoint MUST NOT initiate more than one key update at a time.  A new key
 cannot be used until the endpoint has received and successfully decrypted a
 packet with a matching KEY_PHASE.
 
 A receiving endpoint detects an update when the KEY_PHASE bit doesn't match what
 it is expecting.  It creates a new secret (see Section 7.2 of {{!TLS13}}) and
-the corresponding read key and IV.  If the packet can be decrypted and
-authenticated using these values, then the keys it uses for packet protection
-are also updated.  The next packet sent by the endpoint will then use the new
-keys.
-
-An endpoint doesn't need to send packets immediately when it detects that its
-peer has updated keys.  The next packet that it sends will simply use the new
-keys.  If an endpoint detects a second update before it has sent any packets
-with updated keys it indicates that its peer has updated keys twice without
-awaiting a reciprocal update.  An endpoint MUST treat consecutive key updates as
-a fatal error and abort the connection.
+the corresponding read key and IV.  This uses the same variation on HKDF as

```suggestion
the corresponding read key and IV using the same variation on HKDF as
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1899#pullrequestreview-167681218