Re: [quicwg/base-drafts] Cache git repo, draft references in Circle (#3009)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.

I was concerned that this wouldn't be very much good.

The `{{ .Revision }}` key means that that cache entry is only going to be good for rebuilding that revision, something that we don't do, except when we are tagging a release.  The tag for `{{ .Branch }}` is probably good, but not for `master`, which will be baking in as soon as this lands (if it hasn't already).

The `{{ epoch }}` tag is only good if we run builds within a second of each other.

How about an idea that I just had.  We can run arbitrary code to generate a file.  If we were to write something to a file and then use `{{ checksum ".reference-cache-key" }}` we could ensure that the value rolls over daily so that we have a hot reference cache.  We could do the same for the git cache so that it is mostly at most a certain date old.  You can even cascade caches by reading from `{{ checksum ".cache-today" }}` and `{{ checksum ".cache-yesterday" }}`.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3009#pullrequestreview-285247588