Re: [quicwg/base-drafts] Cache git repo, draft references in Circle (#3009)

Martin Thomson <notifications@github.com> Tue, 10 September 2019 00:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A484612080A for <quic-issues@ietfa.amsl.com>; Mon, 9 Sep 2019 17:19:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ceHF47cleIxd for <quic-issues@ietfa.amsl.com>; Mon, 9 Sep 2019 17:19:22 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3295F120180 for <quic-issues@ietf.org>; Mon, 9 Sep 2019 17:19:22 -0700 (PDT)
Date: Mon, 09 Sep 2019 17:19:21 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568074761; bh=7P7spx4+RyDr50QCq+T3lG0dTeggYfNZABAyzxDI7I8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eigIDJrgT4iISKlv3tKVgVBoVnV5g5Bw2q/mUCGKySVVSzYz1TziH58QpVx8i1rig YgV+/kBKK9BXjsiXRIwfH1W6ivFLuZxqtt4A7OKT7qI1rtiWIwNYXJJVrBjMU1vVN2 bEnDZRhwOfahmU6pzbzSxT+ibqSMBcUr60N1Neic=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZIPCSLDJMXJ2H5FAV3QQIHTEVBNHHB2OXHYQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3009/c529715739@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3009@github.com>
References: <quicwg/base-drafts/pull/3009@github.com>
Subject: Re: [quicwg/base-drafts] Cache git repo, draft references in Circle (#3009)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d76ec093e9fc_6e413fe391ccd96856466"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mMfCj98IV3sGP5e6v-ZiSvnVkbc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Sep 2019 00:19:23 -0000

That's great for now, while there are relatively few new commits to add and the references are fresh.  However, we are creating caches for things that won't ever be used again (``{{ .Revision }}` and `{{ epoch }}`), which takes time that doesn't pay back.

More seriously, the `{{ .Branch }}` thing is a one-time event.  We will always be picking up the cache that you create the first time `master` uses this build.  And the references cache will be old in less than a week now, but that is the cache that will be used in perpetuity.  Sure, this is good in the sense that the build will survive networking blips (assuming that we don't add more citations), but those references will be ancient.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3009#issuecomment-529715739