IETF Logo Mail Archive

Re: [quicwg/base-drafts] Update initial congestion window on MTU decrease (#3998)

ianswett <notifications@github.com> Tue, 18 August 2020 22:07 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 90E8B3A0E1D for <quic-issues@ietfa.amsl.com>; Tue, 18 Aug 2020 15:07:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.555
X-Spam-Level:
X-Spam-Status: No, score=-6.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D-hvBP1GwaQi for <quic-issues@ietfa.amsl.com>; Tue, 18 Aug 2020 15:07:31 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4ACDC3A0857 for <quic-issues@ietf.org>; Tue, 18 Aug 2020 15:07:31 -0700 (PDT)
Received: from github-lowworker-d31a065.va3-iad.github.net (github-lowworker-d31a065.va3-iad.github.net [10.48.17.70]) by smtp.github.com (Postfix) with ESMTP id 843365E0E7C for <quic-issues@ietf.org>; Tue, 18 Aug 2020 15:07:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597788450; bh=1bq2KqO8+yl7Lf6pY/rcafqocM8kVcepR+0ebE302Nk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=S4CjmsTs4NpI7UJy7YO6A1TYWn7s7RUdK7skOgljuP7ULHbuEBGC69qzdQgnsbvD3 rvNaGV/VM6dHScVPt1eRWd9bd7e49ZCQm4agah8OVSqDoQ5wu9GRyImjm94QKHj4NW NyPix17LA9HW6ozOGncjiKt4pjwwYlvUH5iIsSQw=
Date: Tue, 18 Aug 2020 15:07:30 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5GZBTNYRXZQNXUK2V5JAZCFEVBNHHCQ5DTSU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3998/review/469863787@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3998@github.com>
References: <quicwg/base-drafts/pull/3998@github.com>
Subject: Re: [quicwg/base-drafts] Update initial congestion window on MTU decrease (#3998)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3c5122740ff_4ccf19641078f4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/R0m-F-5asS6izXraZ8GvohydCW8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2020 22:07:34 -0000

@ianswett commented on this pull request.



> +If the maximum datagram size is decreased in order to complete the handshake,
+the initial congestion window SHOULD be recalculated with the new smaller size.
+This avoids overly large initial congestion windows.  The initial window is
+not recalculated at any other time.

Not really, I was attempting to make the smallest change that fixed the issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3998#discussion_r472520483

v2.23.0 | Report a Bug | By Email