IETF Logo Mail Archive

Re: [quicwg/base-drafts] nonsensical MUST on frames fitting in packets (#2603)

Kazuho Oku <notifications@github.com> Wed, 10 April 2019 21:27 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6EDA81203C3 for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 14:27:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.001
X-Spam-Level:
X-Spam-Status: No, score=-3.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p3H_O8foS7pb for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 14:27:12 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B74D9120335 for <quic-issues@ietf.org>; Wed, 10 Apr 2019 14:27:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ceIMx6hpnC4MlLjQX1+910ruXWM=; b=uIW5vHvaF5jXSJGV lwzQ1JSqE45kG5rJYxlh93SvfZ+aKzUWYOAsyqC9/8HXYWf9kpdol7h6cdKB7KY9 YMspIZj/O7TkzTFwE13OOJXNtk7sRmvg3PGiv5D0HQ+kq8vYeC2A4oB129Aj/5sn qxxO6SOxJHSINVhPf0WxlsHLCgM=
Received: by filter0380p1iad2.sendgrid.net with SMTP id filter0380p1iad2-16250-5CAE5FAE-11 2019-04-10 21:27:10.570252201 +0000 UTC m=+165171.467751857
Received: from github-lowworker-39ccb07.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0031p1iad2.sendgrid.net (SG) with ESMTP id 2QsAQ24vT-eAAlBz_RLjQQ for <quic-issues@ietf.org>; Wed, 10 Apr 2019 21:27:10.577 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-39ccb07.cp1-iad.github.net (Postfix) with ESMTP id 8A832400C7C for <quic-issues@ietf.org>; Wed, 10 Apr 2019 14:27:10 -0700 (PDT)
Date: Wed, 10 Apr 2019 21:27:10 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab51268fe42ace843339ec1634ca053dc2b98a6d8492cebabb922e92a169ce19b4b084@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2603/c481871735@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2603@github.com>
References: <quicwg/base-drafts/pull/2603@github.com>
Subject: Re: [quicwg/base-drafts] nonsensical MUST on frames fitting in packets (#2603)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cae5fae88735_6dd93fb1eced45bc72420"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1uSbP3O0Di8lO6xwY2sK1WfCgUkvulfhPRy/ Ze6O0wgu4/3hQolgo0F1z6qHdjyWgQhjTlwdqe3Hz28NuZb695P+/J+incwXkRPPNgw7bmeCjRfejs z+Eqf2yOaXYJ2H6Cjq1yg46Mr61OxtJWyageEJ0uZ3n2CFeGEEphFEZGr05uik8liMjpCUmJOEwVcm E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RGNmsII82frp3B4on93bxNqROGw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2019 21:27:13 -0000

I am favor of adopting the PR. Regarding @janaiyengar's concern, maybe we can rephrase the paragragh right before from:

_The payload of QUIC packets, after removing packet protection, commonly consists of a sequence of frames, as shown in Figure 7. Version Negotiation, Stateless Reset, and Retry packets do not contain frames._

to :

_The Payload of QUIC packets, after removing packet protection, consists of a sequence of complete frames, as shown in Figure 7. Version Negotiation, Stateless Reset, and Retry packets do carry the Payload._

Note that the three exceptional packets (VN, Stateless Reset, Retry) do not carry "Payload" by their definition.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2603#issuecomment-481871735

v2.23.0 | Report a Bug | By Email