IETF Logo Mail Archive

Re: [quicwg/base-drafts] Track smallest_newly_acked to prevent spurious RTO (#1822)

ianswett <notifications@github.com> Tue, 02 October 2018 17:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E3931310FA for <quic-issues@ietfa.amsl.com>; Tue, 2 Oct 2018 10:49:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.455
X-Spam-Level:
X-Spam-Status: No, score=-8.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oKaVUBB9tIDO for <quic-issues@ietfa.amsl.com>; Tue, 2 Oct 2018 10:49:03 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 87D9413112E for <quic-issues@ietf.org>; Tue, 2 Oct 2018 10:49:03 -0700 (PDT)
Date: Tue, 02 Oct 2018 10:49:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538502542; bh=3adtCbHeCqGyJUndP5V0ZBsANc8Bi4nUNlZuoI3o2Ok=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0KSW0MuXfHJlydClvt/bPuOzyEo/eIzIh0My+5apH4PuE5NwE0bTzWOAW7c06zbm4 7YkDc6BOdYgkxHONP0EaJbXXPdQPHAfldvh0rYgiyQUE4C4JKq3a2FYHqVaJVxH5Z5 a8qFPdk9NWdU6HQ/jNvmiXfc16rrMjIGSAP2BLic=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd5dbc7c3a7f28b4ae4b63ff5cfe8d1c80c521ff792cf0000000117cb718e92a169ce15d08f48@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1822/review/160844731@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1822@github.com>
References: <quicwg/base-drafts/pull/1822@github.com>
Subject: Re: [quicwg/base-drafts] Track smallest_newly_acked to prevent spurious RTO (#1822)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb3af8ea0b0c_5ddf3fed70ed45c02186b6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SZ77kL2KGzSG2p1erXKrI8bvqpA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 17:49:06 -0000

ianswett commented on this pull request.



>        OnPacketAcked(acked_packet.packet_number)
+    
+    if smallest_newly_acked != 2^62

I was going to, but 0 is a valid packet number.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1822#discussion_r222049387

v2.23.0 | Report a Bug | By Email