IETF Logo Mail Archive

Re: [quicwg/base-drafts] Track smallest_newly_acked to prevent spurious RTO (#1822)

ianswett <notifications@github.com> Tue, 02 October 2018 17:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0FA9213112B for <quic-issues@ietfa.amsl.com>; Tue, 2 Oct 2018 10:48:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.456
X-Spam-Level:
X-Spam-Status: No, score=-3.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KRBMmViLCZWs for <quic-issues@ietfa.amsl.com>; Tue, 2 Oct 2018 10:48:42 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E816D130EAA for <quic-issues@ietf.org>; Tue, 2 Oct 2018 10:48:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=pcZw727AbsOGj9ipPBrIk2VwCN4=; b=TjlPxi/jOrgpBeBd zVC7NSkSPsIBWNkPNdEnS8aFthhbOmSD5L0VSp/KkEK4XvuMHfO+RY7AGgT8pGyX wb4TaUhXIbniMSPAdHEdWrn1qSdTezX2ksOp/a00XF2RD2mOrwcu1H7pjRn+8iZi 4U93/VYKk758VGpGaXWkNqj4shw=
Received: by filter0073p1iad2.sendgrid.net with SMTP id filter0073p1iad2-32043-5BB3AF78-D 2018-10-02 17:48:40.532540879 +0000 UTC m=+338529.305315802
Received: from github-lowworker-f6df7df.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0025p1iad2.sendgrid.net (SG) with ESMTP id _29V7yL-Q8mCmgmLd1AgdA for <quic-issues@ietf.org>; Tue, 02 Oct 2018 17:48:40.531 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-f6df7df.cp1-iad.github.net (Postfix) with ESMTP id 8562B3E02F7 for <quic-issues@ietf.org>; Tue, 2 Oct 2018 10:48:40 -0700 (PDT)
Date: Tue, 02 Oct 2018 17:48:40 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb4d4ad8f81dc5e429e80be2f1eaf281b664ab94692cf0000000117cb717892a169ce15d08f48@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1822/review/160844547@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1822@github.com>
References: <quicwg/base-drafts/pull/1822@github.com>
Subject: Re: [quicwg/base-drafts] Track smallest_newly_acked to prevent spurious RTO (#1822)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb3af787c605_54ce3fcb092d45c4174790"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1p2cNpJLMEcNWwb8JtjWl5ssMtjUTW6S0DtJ kktH+wy5D6ISabmWaqLYa5gi97F++6TDm8ILTK60TwT17LOuWmOwQFqOeoc0aQiNjDYoB5ufBQE53d lDLlkuN/BLsO2RW8jJogirv9Ftg+9NDPBp4KbAHAR/NQuqQBYVbZTv8ctQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/spaQpSya4c7p_iyUKOTAFfAmkPg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 17:48:44 -0000

ianswett commented on this pull request.



> @@ -690,9 +690,22 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
     if (sent_packets[ack.largest_acked]):
       latest_rtt = now - sent_packets[ack.largest_acked].time
       UpdateRtt(latest_rtt, ack.ack_delay)
-    // Find all newly acked packets.
+    // Find all newly acked packets and track the smallest
+    smallest_newly_acked = 2^62
     for acked_packet in DetermineNewlyAckedPackets():

I can comment what it does more clearly, but I don't want to define it.  There are multiple different ways to determine newly acked packets based on one's data structure choices, so I think it's very implementation dependent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1822#discussion_r222049231

v2.23.0 | Report a Bug | By Email